-
-
Notifications
You must be signed in to change notification settings - Fork 136
-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation is no longer enforced for inline editable properties #2828
Comments
The neos.ui has a automated test for that and has the nodetype headline.
This leads to the following result. So this test never fail because of the additional notEmpty validator. |
The StringLength validator will fail when the minimum value is pretty small. The reason is that the value contains the HTML tags as well. So we now strip the tags from the to be validated value. Fixes: neos#2828
The issue was bit tricky and the error can have multiple reasons.
The PR now strips the tags off and that resolves the maximum validation, but for the minimum of 1 we need a NotEmpty validator as well. |
Thanks so much for digging into this Markus! |
The StringLength validator will fail when the minimum value is pretty small. The reason is that the value contains the HTML tags as well. So we now strip the tags from the to be validated value. Fixes: neos#2828
Yes, thanks a ton, Marks. But I'm afraid this ain't solve it yet
What does that mean? The validation rules are persisted with the node? So I can't change the validators afterwards?
I know, that's expected and it works like this in Flow & the Form Framework, too
Right. I had addressed that with neos/flow-development-collection#1849 (see #2579) but that is not related to this bug really (I think at least) |
...another heisenbug. I can't reproduce it any longer. At least not with the Neos.Demo site o.O |
:) I could reproduce the HTML thing. But I maybe had a caching issue with the point 1. Checked the nodedata and the local-storage and redux store and did not find the old config. |
Arg 🤦♂️ while checking that the validators are implemented in the ui itself and not using the PHP validator code I saw that the StringLength validator has an option So we don't need the strip html stuff ... you just need to add this config. |
I'm really sorry for all the fuss.. It turns out, this was just a bug in a customer project of mine that messed with I already expected that and reproduced the bug with a clean Neos.Demo installation but apparently I ran into the caching issue @markusguenther mentioned above, so that my new validation rules were not active immediately.. Closing this one.. Thanks for your help, Markus, I owe you some beers <3 |
There is a subtle change in Neos 5 which changes the behaviour of validation messages though: The |
Turns out this was a regression after all:
doesn't work since there is no Maybe we should take the chance and get rid of the "new" and "old" separation at this point. But that's probably something for |
The neosBackendContainer has been removed with the old emberjs content module. Because this container could not be found the container has been added to the beginning of the body tag. Now we adjust the position to the end of the body section. Fixes: neos#2828
The neosBackendContainer has been removed with the old emberjs content module. Because this container could not be found the container has been added to the beginning of the body tag. Now we adjust the position to the end of the body section. Fixes: #2828
The position has been adjusted an will be released for the next ui version for 5.0 and newer. Thanks for the help guys ❤️ |
Rename the container from neos-new-backend-container to neos-backend-container. The emberjs content module has been removed for 5.0 and now we rename the backend container as we have no old and new one anymore. The can cause issues when the third party code rely on the neos-new-backend-container id. Related: neos#2828
Rename the container from neos-new-backend-container to neos-backend-container. The emberjs content module has been removed for 5.0 and now we rename the backend container as we have no old and new one anymore. The can cause issues when the third party code rely on the neos-new-backend-container id. Related: neos#2828
Rename the container from neos-new-backend-container to neos-backend-container. The emberjs content module has been removed for 5.0 and now we rename the backend container as we have no old and new one anymore. The can cause issues when the third party code rely on the neos-new-backend-container id. Related: neos#2828
Rename the container from neos-new-backend-container to neos-backend-container. The emberjs content module has been removed for 5.0 and now we rename the backend container as we have no old and new one anymore. The can cause issues when the third party code rely on the neos-new-backend-container id. Related: neos#2828
* TASK: Rename neos backend container Rename the container from neos-new-backend-container to neos-backend-container. The emberjs content module has been removed for 5.0 and now we rename the backend container as we have no old and new one anymore. The can cause issues when the third party code rely on the neos-new-backend-container id. Related: #2828 * TASK: Remove conditions of the old emberjs content module
Description
Since #2538 validation could be activated for inline editable properties.
Due to some regression this no longer works with Neos 5.0+
Steps to Reproduce
Adjust the headline node type definition in the demo site:
Open up the homepage (or any other page that contains a headline node) and enter a headline that exceeds 5 characters
Expected behavior
The inline editable should get a red border & display the validation error (see #2538).
It should be impossible to persist / publish the invalid state.
Actual behavior
The validation is completely ignored.
Affected Versions
Neos: 5.0+
UI: 5.1+ (probably also 5.0)
The text was updated successfully, but these errors were encountered: