FEATURE: Make accepted filetypes configurable #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstruebing
commented
Jun 15, 2018
| return this.props.imagesOnly ? 'Image' : 'Asset'; | ||
| } | ||
|
|
||
| acceptedFileTypes = () => { | ||
| if (this.props.imagesOnly) { | ||
| return ['.jpg', '.jpeg', '.png'].reduce((fileTypeString, fileType) => { |
There was a problem hiding this comment.
I'm not sure which image formats I should allow here. Do we have a definition somewhere?
We could/should make it configurable later on I think.
There was a problem hiding this comment.
Well, seeing SVG more and more. Absolutely needs to be configurable. What about jp2, webm, …?
There was a problem hiding this comment.
Good question.
I work on a configurable solution soon.
mstruebing
changed the title
mstruebing
added a commit
to mstruebing/neos-development-collection
that referenced
this pull request
Jun 25, 2018
mstruebing
added a commit
to mstruebing/neos-development-collection
that referenced
this pull request
Jun 25, 2018
dimaip
reviewed
Jun 26, 2018
| @@ -64,6 +65,7 @@ export default class PreviewScreen extends PureComponent { | |||
| highlight={highlight} | |||
| ref={this.setAssetUploadReference} | |||
| imagesOnly={true} | |||
| accept={accept === undefined ? 'image/*' : accept} | |||
There was a problem hiding this comment.
Could as well be accept || 'image/*'?
dimaip
approved these changes
Jun 26, 2018
gerhard-boden
added a commit
to neos/neos-development-collection
that referenced
this pull request
Jun 26, 2018
DOCS: Add accept option to Asset- and Image-Editor Documenting the new accept-option. See: neos/neos-ui#1900
neos-bot
pushed a commit
to neos/neos
that referenced
this pull request
Jun 27, 2018
neos-bot
pushed a commit
to neos/neos
that referenced
this pull request
Jun 27, 2018
DOCS: Add accept option to Asset- and Image-Editor Documenting the new accept-option. See: neos/neos-ui#1900
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes accepted filetypes configurable via the mime type.
If nothing is set for an image editor
image/*is used.You can add accepted filetypes to the editoroptions e.g:
closes #1879