Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: add legacy aloha format migration and support both formats at the same time #2120

Merged
merged 9 commits into from
Sep 12, 2018

Conversation

dimaip
Copy link
Contributor

@dimaip dimaip commented Sep 7, 2018

This PR provides a core migration from old Aloha NodeTypes.yaml format to the new one, but also allows both formats to exist at the same time.

The old aloha format and the new format are supported at the same time, the new format takes precedence.

@dimaip dimaip changed the title TASK: add legacy aloha format migration TASK: add legacy aloha format migration and support both formats at the same time Sep 7, 2018
@kdambekalns
Copy link
Member

Moved from PR comment:


How to verify

The migration should convert the old format to the new one:

./flow flow:core:migrate Neos.NodeTypes.BaseMixins --version 20180907103800

Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine on the base mixins, and the code looks as if it would work elsewhere, too. Great!

@dimaip dimaip merged commit 8c0605a into neos:master Sep 12, 2018
@dimaip dimaip deleted the aloha-migration branch September 12, 2018 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants