Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: esbuild #3200

Merged
merged 79 commits into from
Nov 24, 2022
Merged

FEATURE: esbuild #3200

merged 79 commits into from
Nov 24, 2022

Commits on Oct 7, 2022

  1. wip

    JamesAlias committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    26c3176 View commit details
    Browse the repository at this point in the history
  2. wip

    JamesAlias committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    81ad03b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ba89431 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2f7b36d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2210b1a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    34b767a View commit details
    Browse the repository at this point in the history
  7. WIP: Fix Build

    - Iframe Host Styles
    - HostOnlyStyles
    - fortawesome string replace
    mhsdesign authored and JamesAlias committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    8c36723 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f586f46 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7ca28b6 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    46cc58a View commit details
    Browse the repository at this point in the history
  11. WIP: STYLES WORK

    JamesAlias committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    8a17fcd View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    71a513b View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    db8e2fa View commit details
    Browse the repository at this point in the history
  14. WIP: ckeditor load svg as text

    mhsdesign authored and JamesAlias committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    8fb108a View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    b5d2357 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    413ebea View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    6c5fb83 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    bf11fc3 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    4c05f19 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    27e42f0 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    9e9d58d View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    42dd54d View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2022

  1. Configuration menu
    Copy the full SHA
    09fc4c4 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2022

  1. Configuration menu
    Copy the full SHA
    354a1db View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. Wip: Define global as alias for window to make react-dnd work again

    #3200 (comment)
    
    we somehow have a dependency which uses global and because we where lazy we just defined in esbuild to insert for `global` an empty object `{}` like: we dont care.
    
    i forgot about that line in the build script and dindt gave it much mlre attention - and considered it harmless
    
    after playing debugging randomly and lately playing divide and conquer i found out that react-dnd uses either `global` (if defined) or `window` to store things - that broke it (as global was now everytime replaced with an empy object -> see esbuild 'define') :verschwitztes_lachen:
    
    the hotfix is `global = window`
    
    but ill try to narrow down the problem to fix it more accurately
    mhsdesign committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    4e17c7a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    45db0ce View commit details
    Browse the repository at this point in the history
  3. Wip: Better way to fix react-codemirror2 global ussage

    I find using `'global': 'window'` gives us not enough control about when it was accidentally used
    
    #3200 (comment)
    mhsdesign committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    ebc1e70 View commit details
    Browse the repository at this point in the history
  4. Wip: ClientEval: use new Function instead of unsave eval

    Removes the warning
    Using direct eval with a bundler is not recommended and may cause problems
    
    see https://esbuild.github.io/link/direct-eval
    mhsdesign committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    2ec67f5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    852cf86 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d0fd83a View commit details
    Browse the repository at this point in the history
  7. Wip: Build the ui without make build-subpackages

    it does produces a better bundle to use the source files
    
    later we need to rethink the distribution of npm splits
    mhsdesign committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    d40cd2a View commit details
    Browse the repository at this point in the history
  8. WIP: REVERT: use standard css variables

    rollback css var rename (and not using postcss var replace) only for now so this pr becomes easier to review
    
    reverts
    - f586f46
    - 7ca28b6
    
    undos sugestion #3201
    mhsdesign committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    66ddd2b View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. Merge remote-tracking branch 'composer/8.2' into feature/esbuild

    # Conflicts:
    #	packages/react-ui-components/src/DropDown/style.scss
    markusguenther committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    a18d54c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    135c512 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    de3346e View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. Merge remote-tracking branch 'composer/8.2' into feature/esbuild

    # Conflicts:
    #	packages/neos-ui-editors/src/SecondaryEditors/ImageCropper/index.js
    markusguenther committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    747dbe1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e720f2f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3e29d87 View commit details
    Browse the repository at this point in the history
  4. TASK: Upgrade eslint and babel

    Use babel 7 and eslint 8
    markusguenther committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    96bff45 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    835d028 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. Merge remote-tracking branch 'composer/8.2' into feature/esbuild

    # Conflicts:
    #	packages/neos-ui/src/Containers/LeftSideBar/style.css
    #	packages/neos-ui/src/Containers/RightSideBar/style.css
    #	yarn.lock
    markusguenther committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    ac89cab View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    baf0031 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    adc59fd View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. Configuration menu
    Copy the full SHA
    3427593 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ed7af58 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    39fede9 View commit details
    Browse the repository at this point in the history
  4. TASK: Upgrade testcafe

    Sebobo committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    028f062 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d362941 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2022

  1. Configuration menu
    Copy the full SHA
    f33fae8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2ab2af2 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2022

  1. TASK: Esbuild keepNames: true for react magic selector in e2e

    We found out that this fixes the problem for unit snapshot testing, and most likely will fix also e2e
    
    Watch out the option will increase the bundle size around 100 bytes.
    3.9 -> 4.0
    
    Once we have less time we might start a quick separate e2e build ;)
    mhsdesign committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    a273b9e View commit details
    Browse the repository at this point in the history
  2. Revert changes to ReactSelectors

    These were now unnecessary as the problems were fixed via the esbuild config
    Sebobo committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    49530ea View commit details
    Browse the repository at this point in the history
  3. WIP: Fix jest: custom esbuild transform

    - jest fix circular dependency
    - fix jest module field package.json (requires at least jest 24)
    - remove test script from neos-ui-constants (no tests)
    - jest transform all files (except 2 js libs)
    - fix snapshot tests by using keepNames true
    mhsdesign committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    d45c380 View commit details
    Browse the repository at this point in the history
  4. Task: update jest to v27

    mhsdesign committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    390e8de View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. Configuration menu
    Copy the full SHA
    791f0ed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5eb3e9d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3e0b731 View commit details
    Browse the repository at this point in the history
  4. Task: make linter happier

    mhsdesign committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    d09b2eb View commit details
    Browse the repository at this point in the history
  5. Task: make sure esbuild transpiles tests also in strict mode

    fixes:
    ```
    FAIL src/index.spec.js
      ● should not be writable.
    
        expect(received).toThrow()
    
        Received function did not throw
    
          at Object.<anonymous> (src/<stdin>:82:16)
    ```
    
    and
    
    ```
    FAIL src/createConsumerApi.spec.js (7.141 s)
      ● "createConsumerApi" should create a global, read-only object
    
        expect(received).toThrow()
    
        Received function did not throw
    
          at Object.<anonymous> (src/<stdin>:12:25)
    
      ● "createConsumerApi" should expose the passed api, with each key being read-only
    
        expect(received).toThrow()
    
        Received function did not throw
    
          at Object.<anonymous> (src/<stdin>:33:26)
    ```
    mhsdesign committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    53805ba View commit details
    Browse the repository at this point in the history
  6. Merge pull request #3254 from neos/feature/esbuild-jest-tests

    WIP: Feature esbuild jest tests
    mhsdesign committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    00d5282 View commit details
    Browse the repository at this point in the history
  7. Task: Esbuild special e2e testing build

    build is slightly bigger but works with the react magic selector
    mhsdesign committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    968b27d View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a976c37 View commit details
    Browse the repository at this point in the history
  9. TAKS: Revert moving jest config into jest preset

    This reverts commit 9462771.
    and
    This reverts commit ae99b80.
    mhsdesign committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    9a4a4a4 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    1ebce46 View commit details
    Browse the repository at this point in the history
  11. Task: adjust Make

    mhsdesign committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    9da6a17 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. Merge remote-tracking branch 'composer/8.2' into feature/esbuild

    # Conflicts:
    #	.eslintrc
    #	package.json
    #	packages/neos-ui-editors/src/SecondaryEditors/CodeMirrorWrap/index.js
    #	packages/neos-ui-editors/src/SecondaryEditors/ImageCropper/index.js
    #	packages/react-ui-components/.eslintrc
    #	yarn.lock
    markusguenther committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    c3f3727 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3605abb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5e6cb98 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2022

  1. Configuration menu
    Copy the full SHA
    a61f9e0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    43035d1 View commit details
    Browse the repository at this point in the history
  3. FEATURE: Include notosans from npm

    Reduces font size by 50%
    Sebobo committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    50fae3b View commit details
    Browse the repository at this point in the history
  4. TASK: Remove old files

    Sebobo committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    ed3326c View commit details
    Browse the repository at this point in the history
  5. TASK: Lint esbuild.js

    Sebobo committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    c56e3a2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    519d210 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8260fc1 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c2c1515 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3436062 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    e89e4ae View commit details
    Browse the repository at this point in the history
  11. Task: Move compiled assets to Build folder and fix jenkins

    legal comments are now also separate
    mhsdesign committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    ccffca4 View commit details
    Browse the repository at this point in the history