Fix AppImage support and Dockerfile for testing #1941
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
The appimage is now built with the oldest available Ubuntu release 20.04, for maximum compatibility. We could go even older than that, but the Github CI does not support it.
Furthermore, we use
--locked
for building to ensure that the dependencies are correct.A
.zsync
file is added to support auto-updates with for example https://github.com/TheAssassin/AppImageLauncherNote in order to be able to upload to the appimage hub we need to package this https://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html#sect-Quickstart-DesktopApps, built with the creator https://www.freedesktop.org/software/appstream/metainfocreator/#/guiapp. I have not done that, since we need some nice screenshots and other information. Could someone do that, and I will apply it here?
Then this file also needs to be packaged with the AppImage.
I have tested this with Ubuntu 20.04, 22.04 and 23.04 and Fedora 35, and it works correctly in all of those, which are a mix of Wayland and X11.
In the folder
ubuntu-builder
I have added aDockerfile
and some scripts to build withpodman
usermode using ubuntu 20.04, in order to be able to simulate the CI environment locally.Finally, I have not updated neovide.desktop (specification)
neovide/assets/neovide.desktop
Lines 1 to 9 in eeac6e7
But I think it should be updated with the following changes
Neovide
Utility;Development
, like KDE Kate for example. See the specification. This controls in which menu folders Neovide will show.TextEditor;IDE
Do you agree with these changes? If so, I will do that.
Did this PR introduce a breaking change?
NOTE:, when doing releases the appimage and
zsync
should be uncompressed. The CI artifacts are always compressed.This can be automated using https://github.com/TheAssassin/pyuploadtool. And then it can even create proper releases for
Continuous build
which is always the latest master, which we can link to when we need testing of the master.