Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AppImage support and Dockerfile for testing #1941

Merged
merged 2 commits into from
Jul 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 17 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [windows-latest, macOS-11, ubuntu-latest]
# NOTE: Should use the oldest available Ubuntu release, for maximum compatibility
os: [windows-latest, macOS-11, ubuntu-20.04]
runs-on: ${{ matrix.os }}

steps:
Expand Down Expand Up @@ -143,14 +144,14 @@ jobs:
elif [[ $RUNNER_OS == "macOS" ]]; then
echo "MACOSX_DEPLOYMENT_TARGET=10.11" >> $GITHUB_ENV
# x86
cargo build --release --target=x86_64-apple-darwin
cargo build --locked --release --target=x86_64-apple-darwin
cargo bundle --release --target=x86_64-apple-darwin
# arch
cargo build --release --target=aarch64-apple-darwin
cargo build --locked --release --target=aarch64-apple-darwin
cargo bundle --release --target=aarch64-apple-darwin

elif [[ $RUNNER_OS == "Linux" ]]; then
cargo build --release
cargo build --locked --release
fi

- name: Prepare Artifacts
Expand Down Expand Up @@ -186,17 +187,22 @@ jobs:
# create appimage
curl -Lo linuxdeploy https://github.com/linuxdeploy/linuxdeploy/releases/latest/download/linuxdeploy-x86_64.AppImage
chmod +x linuxdeploy
curl -Lo linuxdeploy-plugin-appimage https://github.com/linuxdeploy/linuxdeploy-plugin-appimage/releases/latest/download/linuxdeploy-plugin-appimage-x86_64.AppImage
chmod +x linuxdeploy-plugin-appimage

export LDAI_OUTPUT=neovide.AppImage
export LDAI_UPDATE_INFORMATION="gh-releases-zsync|neovide|neovide|latest|neovide.AppImage.zsync"
./linuxdeploy \
--executable=neovide \
--desktop-file=../../assets/neovide.desktop \
--appdir=AppDir \
--icon-file=../../assets/neovide.svg \
--output=appimage

mv Neovide_\(nvim\)-*.AppImage neovide.AppImage

echo "ARTIFACT=neovide-linux-x86_64.tar.gz" >> $GITHUB_ENV
echo "ARTIFACT2=neovide.AppImage" >> $GITHUB_ENV
echo "ARTIFACT3=neovide.AppImage.zsync" >> $GITHUB_ENV
fi

- uses: actions/upload-artifact@v3
Expand All @@ -209,3 +215,9 @@ jobs:
with:
name: ${{ env.ARTIFACT2 }}
path: target/release/${{ env.ARTIFACT2 }}

- if: env.ARTIFACT3
uses: actions/upload-artifact@v3
with:
name: ${{ env.ARTIFACT3 }}
path: target/release/${{ env.ARTIFACT3 }}
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/target
/target-ubuntu
/.vs
**/*.rs.bk
*.log
Expand Down