Improve test TestAPI/Extmarks/Batch

Do not make assumptions about how nvim_buf_set_extmark() assigns IDs. Validate that SetBufferExtmark returned the correct ID by relying on existing test code code that compares the returned ID with the results from BufferExmarks.
neovim · May 14, 2024 · 1987893 · 1987893
1 parent 77f98f1
commit 1987893
Showing 1 changed file with 6 additions and 14 deletions.
diff --git a/nvim/api_test.go b/nvim/api_test.go
@@ -4303,17 +4303,13 @@ func testExtmarks(v *Nvim) func(*testing.T) {
 			}
 
 			const (
-				wantExtMarkID = 1
-				wantLine      = 1
-				wantCol       = 3
+				wantLine = 1
+				wantCol  = 3
 			)
 			gotExtMarkID, err := v.SetBufferExtmark(Buffer(0), nsID, wantLine, wantCol, make(map[string]interface{}))
 			if err != nil {
 				t.Fatal(err)
 			}
-			if gotExtMarkID != wantExtMarkID {
-				t.Fatalf("got %d extMarkID but want %d", gotExtMarkID, wantExtMarkID)
-			}
 
 			extmarks, err := v.BufferExtmarks(Buffer(0), nsID, 0, -1, make(map[string]interface{}))
 			if err != nil {
@@ -4323,7 +4319,7 @@ func testExtmarks(v *Nvim) func(*testing.T) {
 				t.Fatalf("expected extmarks length to 1 but got %d", len(extmarks))
 			}
 			if extmarks[0].ID != gotExtMarkID {
-				t.Fatalf("got %d extMarkID but want %d", extmarks[0].ID, wantExtMarkID)
+				t.Fatalf("got %d extMarkID but want %d", extmarks[0].ID, gotExtMarkID)
 			}
 			if extmarks[0].Row != wantLine {
 				t.Fatalf("got %d extmarks Row but want %d", extmarks[0].Row, wantLine)
@@ -4382,18 +4378,14 @@ func testExtmarks(v *Nvim) func(*testing.T) {
 			}
 
 			const (
-				wantExtMarkID = 2
-				wantLine      = 1
-				wantCol       = 3
+				wantLine = 1
+				wantCol  = 3
 			)
 			var gotExtMarkID int
 			b.SetBufferExtmark(Buffer(0), nsID, wantLine, wantCol, make(map[string]interface{}), &gotExtMarkID)
 			if err := b.Execute(); err != nil {
 				t.Fatal(err)
 			}
-			if gotExtMarkID != wantExtMarkID {
-				t.Fatalf("got %d extMarkID but want %d", gotExtMarkID, wantExtMarkID)
-			}
 
 			var extmarks []ExtMark
 			b.BufferExtmarks(Buffer(0), nsID, 0, -1, make(map[string]interface{}), &extmarks)
@@ -4405,7 +4397,7 @@ func testExtmarks(v *Nvim) func(*testing.T) {
 				t.Fatalf("expected extmarks length to 1 but got %d", len(extmarks))
 			}
 			if extmarks[0].ID != gotExtMarkID {
-				t.Fatalf("got %d extMarkID but want %d", extmarks[0].ID, wantExtMarkID)
+				t.Fatalf("got %d extMarkID but want %d", extmarks[0].ID, gotExtMarkID)
 			}
 			if extmarks[0].Row != wantLine {
 				t.Fatalf("got %d extmarks Row but want %d", extmarks[0].Row, wantLine)