This repository has been archived by the owner on Aug 8, 2018. It is now read-only.
[RFC] Formula: Reorder CMake flags. #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMAKE_BUILD_TYPE=RelWithDebInfo must come at the end to take effect, as std_cmake_args contains CMAKE_BUILD_TYPE=Release. Change the order while retaining Ruby 1.8 compatibility.
fwalch
force-pushed
the
formula/reorder-flags
branch
from
1a655f0
to
833bdae
Compare
|
Yep, that seems to compile for me. |
|
Thanks for testing!
We only specify custom flags there, so it should be fine. |
|
👍 Thank you @fwalch |
fwalch
added a commit
that referenced
this pull request
Jul 26, 2015
CMAKE_BUILD_TYPE=RelWithDebInfo must come at the end to take effect, as std_cmake_args contains CMAKE_BUILD_TYPE=Release. Change the order while retaining Ruby 1.8 compatibility.
sts10
added a commit
to sts10/homebrew-neovim
that referenced
this pull request
Oct 28, 2015
Change symlink targets to point to the new location of Neovim's config files. I think the change was fairly recent, as per [this Reddit thread](https://www.reddit.com/r/neovim/comments/3qgsza/psa_if_neovim_stopped_loading_your_nvimrc_after/), which points to a [issue neovim#78](neovim/neovim#78).
sts10
added a commit
to sts10/homebrew-neovim
that referenced
this pull request
Oct 28, 2015
Change symlink targets to point to the new location of Neovim's config files. I think the change was fairly recent, as per [this Reddit thread](https://www.reddit.com/r/neovim/comments/3qgsza/psa_if_neovim_stopped_loading_your_nvimrc_after/), which points to [issue neovim#78](neovim/neovim#78).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMAKE_BUILD_TYPE=RelWithDebInfo must come at the end to take effect,
as std_cmake_args contains CMAKE_BUILD_TYPE=Release.
Change the order while retaining Ruby 1.8 compatibility.
@soli Can you confirm that this still works?