Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift-mouse starts visual mode in terminal #2520

Closed
blueyed opened this issue Apr 27, 2015 · 4 comments
Closed

Shift-mouse starts visual mode in terminal #2520

blueyed opened this issue Apr 27, 2015 · 4 comments
Labels
bug issues reporting wrong behavior tui
Milestone

Comments

@blueyed
Copy link
Contributor

blueyed commented Apr 27, 2015

I am using urxvt / rxvt-unicode as a terminal, and have set mouse=a.

When I want to select text from the terminal window, I use "Shift" while clicking and dragging the text (or double-clicking it).

With Neovim, this can trigger/start the visual mode, while it gets ignored correctly by vanilla Vim. This appears to only happen after the mouse has been used once to trigger the visual mode.
In this case both Neovim and rxvt-unicode appear to manage their selections - the issue is not that just visual mode is started (as if Shift wasn't used).

TEST CASE:

  1. nvim -u NONE
  2. :set mouse=a
  3. use the mouse to start visual mode (click and drag)
  4. Escape
  5. Use the mouse with Shift pressed to select text

Using "Shift-mouse" before visual mode is being triggered through the mouse works.
It's not a problem with gnome-terminal.

Visual mode should not get triggered again, but it is.

@justinmk justinmk added bug issues reporting wrong behavior terminal labels Apr 27, 2015
@mhinz
Copy link
Member

mhinz commented Apr 28, 2015

Maybe related: #2383

@blueyed
Copy link
Contributor Author

blueyed commented Apr 28, 2015

Thanks, @mhinz.
I've tried your one-line fix, but is does not help - it's not related to the tabline also.
But the issue is similar indeed.

@justinmk justinmk added this to the todo milestone Jul 1, 2015
blueyed added a commit to blueyed/rxvt-unicode that referenced this issue Jul 12, 2015
Without this shifted mouse-dragging would be reported to the app (via
1002 in DECSET).
This makes Neovim start visual selection for example.

Fixes neovim/neovim#2520.
@blueyed
Copy link
Contributor Author

blueyed commented Aug 5, 2015

It turned out to be a bug in rxvt-unicode (see the above commit, blueyed/rxvt-unicode@b5594fc).

Submitted for rxvt-unicode at: http://lists.schmorp.de/pipermail/rxvt-unicode/2015q3/002145.html.

@blueyed blueyed closed this as completed Aug 5, 2015
@justinmk
Copy link
Member

justinmk commented Aug 5, 2015

Thanks for the followup.

@justinmk justinmk added tui and removed terminal labels Dec 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issues reporting wrong behavior tui
Projects
None yet
Development

No branches or pull requests

3 participants