[RDY] Fix visual selection after left click on tabline

[mhinz]

After left clicking on a tab in the tabline, the in_tab_line variable wasn't
set to false and every following mouse action assumed still being on the
tabline which messed up visual selection etc.

References #2382.

[tarruda]

LGTM, only need to add a functional test(which should be easy, have a look at some tests in mouse_spec.lua)

[splinterofchaos]

LGTM, though I'm not fully familiar with do_mouse. I compared this code against vanilla vim and it looks like the same bug should exist there, but I could not get the mouse to work for some reason. Would you consider sending a patch upstream?

[mhinz]

Added an UI test.

I'll investigate why the same bug doesn't happen with Vim.

[mhinz]

So.. now there are 2 new tests.

The first just checks if left clicking on a tab in the tabline switches to that tabpage.

The second checks if visual selection is still working after a tab in the tabline was left clicked.. and currently that test fails, even after the one-line fix. Instead it switches the places of the tabs which is the actual bug. It works if I try it manually though..

I'll dig deeper.

[tarruda]

@mhinz a little tip: You can attach a pynvim GUI to one of the tests with a Screen.debug() statement. This allows you to see and interact with the screen being tested. You need a pygtk3 environment which you can install in pyenv with this script(or install dependencies manually using the system package manager)

[unphased]

So I ran into this bug and i'm pretty happy that there is a fix. Any chance the PR can get merged? Maybe the PR just needs a little merging to get the CI to pass

[mhinz]

The fix (mhinz@a1543e2) is working, but the tests don't act as if a user would click around manually. The test itself should be also correct, but something else has to changed yet.

Any pointers are welcome.

[splinterofchaos]

@mhinz Might the test need a <LeftRelease> somewhere to prevent the code from thinking the cursor had been dragged from the tab line?

[mhinz]

@splinterofchaos Uhm.. thank you!

[unphased]

Woo! i would love to see this fixed in neovim

[splinterofchaos]

Looks like the tests are still failing for the same reason. I'm not familiar with the mouse handling code, nor <LeftMoust> events, but are we sure the tests are correct? If so, is this possibly a bug in the input handling?

[mhinz]

Hmm, inserting the <LeftRelease> like in the latest commit, makes all tests pass for me locally.

Actually it fails because for another reason now.. before the <LeftRelease> the tabs would end up switched. Now they're in order but the highlight groups are mixed up, as if the wrong tab is focused (the first instead of the second one).

[mhinz]

Should be working now.

[splinterofchaos]

LGTM 👍

[mhinz]

Can this be merged?

[thor85]

I have the same issue with NVIM v0.2.2
I use airline and show buffers in tabline. Whenever I change to a different buffer by clicking the tabline I can no longer select anything with the mouse.

[mhinz]

@thor85 Can you reproduce it with nvim -u NORC +'tabnew foo | tabnew bar | set mouse=a'?

[thor85]

Yea have the same problem then. If I hold down and move the mouse I'm just moving the tabs around.

[mhinz]

If I hold down and move the mouse I'm just moving the tabs around.

Okay, that's expected behaviour. But afterwards you can't click anything in the tabline anymore, right?

[thor85]

No I mean if I click and hold to select some text, it will not select text, but move the tab around.

So when I first open nvim I can select text fine with the mouse. If I change tab with :tabn I can still select text. If I change tab with a mouse click, I cannot select text anymore. Clicking the mouse anywhere just seems like it clicks the tab bar. Have not found any way to reset it except exiting nvim and start over again.

[mhinz]

Do you use an actual mouse or an trackpad? Do you use tmux?

I tested around a bit and I can reproduce a similar issue when "tapping" a tab in the tabline and then trying to select something. When I use a "full left-click" by pressing the trackpad all the way to the buttom (until it clicks), everything works as expected.

We currently believe that it's a bug in the terminal/tmux, because trackpad tapping and clicking should be handled exactly the same, but it feels as if with tapping there's no proper release. Then Nvim thinks you're still dragging in the tabline.

I can reproduce it with Terminal.app and tmux, but not without tmux. I can't reproduce it with iTerm2 at all.

[thor85]

I use an actual mouse. I do use tmux, but I tried without tmux now and got the same problem. I usually use urxvt, but tried gnome terminal and got the same.

However, this is not running directly on my pc. I use a windows laptop to connect with HP RGS to the linux server and run from there, so maybe that could be why the mouse acts weird. I don't have a linux pc available to test right now.

[mhinz]

@thor85 I'm not sure how to help you right now. I think it would be best if you'd open a new issue and describe the issue again with as many details about your environment as possible.