Fix for issue #11205 :terminal

[ghost]

Changing the line termination from \n to \r. Fixing an issue, where the :terminal powershell would have its paste in reverse order.
Checked on windows as well as on mac with powershell core.

Fixes #11205.

[bfredl]

Makes sense. Could you update the failing tests? (and check that they will fail for the old behavior, maybe that is enough for tests then).

[ghost]

I'll do so as soon as I get back to my windows machine.

[justinmk]

@Liberatys what changed in the latest push? Do you plan to update the tests any time soon?

[ghost]

@justinmk I have to apologize. I had a lot going on and always pushed it. After multiple times of going through the tests and trying to figure out what to change .. I have to admit that I don't seem to get how to test for the new behaviour.
I'm sorry.

Could someone with more knowledge finish this fix? Thank you very much.

[blueyed]

Pushed a lint fix.
It does not look like there are failing tests (the ones on AppVeyor looked unrelated, but maybe I misunderstood and they can be used for testing this change).

[blueyed]

AppVeyor failures are relevant:

[  FAILED  ] 2 tests, listed below:
[  FAILED  ] test/functional\terminal\buffer_spec.lua @ 86: :terminal buffer sends data to the terminal when the "put" operator is used
test/functional\terminal\buffer_spec.lua:90: Row 2 did not match.
Expected:
  |^tty ready                                         |
  |*appended tty ready                                |
  |*appended tty ready                                |
  |*{2: }                                                 |
  |                                                  |
  |                                                  |
  |:let @a = "appended " . @a                        |
Actual:
  |^tty ready                                         |
  |*{2:a}ppended tty ready                                |
  |*                                                  |
  |*                                                  |
  |                                                  |
  |                                                  |
  |:let @a = "appended " . @a                        |
To print the expect() call that would assert the current screen state, use
screen:snapshot_util(). In case of non-deterministic failures, use
screen:redraw_debug() to show all intermediate screen states.  
stack traceback:
	test\functional\ui\screen.lua:579: in function '_wait'
	test\functional\ui\screen.lua:361: in function 'expect'
	test/functional\terminal\buffer_spec.lua:90: in function <test/functional\terminal\buffer_spec.lua:86>
[  FAILED  ] test/functional\terminal\buffer_spec.lua @ 112: :terminal buffer sends data to the terminal when the ":put" command is used
test/functional\terminal\buffer_spec.lua:116: Row 2 did not match.
Expected:
  |^tty ready                                         |
  |*appended tty ready                                |
  |*{2: }                                                 |
  |                                                  |
  |                                                  |
  |                                                  |
  |:put a                                            |
Actual:
  |^tty ready                                         |
  |*{2:a}ppended tty ready                                |
  |*                                                  |
  |                                                  |
  |                                                  |
  |                                                  |
  |:put a                                            |
To print the expect() call that would assert the current screen state, use
screen:snapshot_util(). In case of non-deterministic failures, use
screen:redraw_debug() to show all intermediate screen states.  
stack traceback:
	test\functional\ui\screen.lua:579: in function '_wait'
	test\functional\ui\screen.lua:361: in function 'expect'
	test/functional\terminal\buffer_spec.lua:116: in function <test/functional\terminal\buffer_spec.lua:112>

Code for the first one:

neovim/test/functional/terminal/buffer_spec.lua

Lines 86 to 98 in 5b6466a

	it('sends data to the terminal when the "put" operator is used', function()
	feed('<c-\\><c-n>gg"ayj')
	feed_command('let @a = "appended " . @a')
	feed('"ap"ap')
	screen:expect([[
	^tty ready |
	appended tty ready |
	appended tty ready |
	{2: } |
	|
	|
	:let @a = "appended " . @a |
	]])

Should "\r" only be used for Powershell then maybe?

[justinmk]

Would be great to finish this...

[NilsIrl]

Suggested change

	terminal_send(curbuf->terminal, "\r", 1);
	terminal_send(curbuf->terminal, "\r\n", 2);

This might do it? (untested)

[NilsIrl]

I'm not sure what are the different possible platforms are. But would it be possible to have a non-unix platform that doesn't use \r\n?

If this is the case, it would mean they would fall under the #else and receive the wrong characters.

[NilsIrl]

Sorry, I haven't really been following. Why close this?

[ghost]

@NilsIrl Oh wow .. I'm sorry ^^ I was rechecking what you wrote before and wanted write a comment... must have slipped .. sry. Currently checking your reviews on my machines.

[ghost]

The conditional sending of \n and \r\n as proposed by @NilsIrl to the terminal seem to pass on the appveyor test and also worked on my local machine.

The failure in builds.sr.ht: openbsd.yml is unrelated to the change.

The failures in continuous-integration/travis-ci/pr seem to be related to the change.

s390x - big-endian

[ FAILED ] 1 test, listed below:
[ FAILED ] test/functional/terminal/scrollback_spec.lua @ 481: 'scrollback' option :setlocal in a :terminal buffer
test/helpers.lua:73: bad argument #2 to 'format' (string expected, got table)

AMD64 - gcc-32bit

Failed: 0 Tests
reset: standard error: Inappropriate ioctl for device
++fail oldtests F 'Legacy tests failed'

Which both make no sense to me, because Linux xenial shouldn't be influenced by the change.

[dundargoc]

Superseded by #18723