Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickfix.c: Fix vimgrep regression #11907

Merged
merged 1 commit into from
Feb 20, 2020
Merged

quickfix.c: Fix vimgrep regression #11907

merged 1 commit into from
Feb 20, 2020

Conversation

cballam
Copy link
Contributor

@cballam cballam commented Feb 19, 2020

Fix ex_vimgrep to properly ignore filetype when running vimgrep.
This restores vimgrep to behaviour before function refactoring.

fix #11856 Fix #9842

Simple fix caused by a slight regression from refactoring of ex_vimgrep, the au_event_disable wasn't moved from the original function. The fix has been moved below the comment about a speed improvement as this is what causes the speed improvement, it was not relevant to the save_mls or p_mls variables.

@janlazo
Copy link
Contributor

janlazo commented Feb 20, 2020

Fix #9842 and 9d6c205 is the merge commit.

Please rebase to fix the commit message with the right links.

Fix ex_vimgrep to properly ignore filetype when running vimgrep.
This restores vimgrep to behaviour before function refactoring.

fix #9842
fix #11856
@cballam
Copy link
Contributor Author

cballam commented Feb 20, 2020

Apologies for my terrible git skills, they've gotten rusty. Does this latest commit message follow proper convention?

@justinmk justinmk merged commit 9897ad3 into neovim:master Feb 20, 2020
justinmk pushed a commit that referenced this pull request Feb 20, 2020
Fix ex_vimgrep to properly ignore filetype when running vimgrep.
This restores vimgrep to behaviour before function refactoring.

fix #9842
fix #11856
@justinmk justinmk added this to the 0.4.4 milestone Feb 20, 2020
@justinmk
Copy link
Member

backported to stable branch. 5d41bfc

many thanks @cballam and @lacygoill

jamessan added a commit that referenced this pull request Aug 5, 2020
Maintenance release for v0.4.x series.

FIXES:

fd02e63 #12701 ui: fix problem with sattr_T overflow
3e3002b #12710 fs: Ensure FileInfo struct is initialized
e4629f2 #12496 main.c: fix hang issue with recoverymode #12520
f558af8 #12209 fixed hang issue with --headless and -r option specified
cda1190 #12180 TUI: block signals on suspend
8399f73 #12142 Fix issues revealed by gcc10 setting -fno-common by default
5e47cf2 netrw.vim: do not save +/* registers
5d41bfc #11907 quickfix.c: Fix vimgrep regression
641e229 #11903 screen: add missing redraws after a message
47bd62c loop_close: close all handles
d273036 loop_close: call uv_stop(), fix bug
284b398 #11821 loop_close: timout after 2 seconds
1b2666c messages: echo "line1\r\nline2" should not clear line1
1bf90bf #11651 API: fix crash on copy_object(kObjectTypeWindow)
fafd636 #11566 libcallnr: Use int, not int64_t, as the return type for Vim compat
972dd75 #11460 win_line: Fix crash with 'rightleft' in :terminal
4c48cf3 f_getenv/setenv: Access v_special when v_type is VAR_SPECIAL
2cd1ff7 #11360 paste: Select-mode, Visual-mode
qvacua added a commit to qvacua/neovim that referenced this pull request Aug 12, 2020
NVIM v0.4.4

Maintenance release for v0.4.x series.

FIXES:

fd02e63 neovim#12701 ui: fix problem with sattr_T overflow
3e3002b neovim#12710 fs: Ensure FileInfo struct is initialized
e4629f2 neovim#12496 main.c: fix hang issue with recoverymode neovim#12520
f558af8 neovim#12209 fixed hang issue with --headless and -r option specified
cda1190 neovim#12180 TUI: block signals on suspend
8399f73 neovim#12142 Fix issues revealed by gcc10 setting -fno-common by default
5e47cf2 netrw.vim: do not save +/* registers
5d41bfc neovim#11907 quickfix.c: Fix vimgrep regression
641e229 neovim#11903 screen: add missing redraws after a message
47bd62c loop_close: close all handles
d273036 loop_close: call uv_stop(), fix bug
284b398 neovim#11821 loop_close: timout after 2 seconds
1b2666c messages: echo "line1\r\nline2" should not clear line1
1bf90bf neovim#11651 API: fix crash on copy_object(kObjectTypeWindow)
fafd636 neovim#11566 libcallnr: Use int, not int64_t, as the return type for Vim compat
972dd75 neovim#11460 win_line: Fix crash with 'rightleft' in :terminal
4c48cf3 f_getenv/setenv: Access v_special when v_type is VAR_SPECIAL
2cd1ff7 neovim#11360 paste: Select-mode, Visual-mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

":vimgrep" too slow when filetype detection is enabled
3 participants