fixed hang issue with --headless and -r option specified #12209

Code-Hex · 2020-04-29T14:34:41Z

fixed #11386 issues.

Calling the do_more_prompt function in headless mode will freeze neovim because it is eventally in the input-accepting state (the same as waiting for --more--).

I have tried

nvim -u NORC -c 'for i in range(0, 1000) | echo i | endfor | quit' --headless
nvim -u NORC -r

Calling the do_more_prompt function in headless mode will freeze neovim because it is eventally in the input-accepting state (the same as waiting for --more--).

Code-Hex · 2020-04-29T14:45:34Z

By the way, I think this "Press ENTER or type command to continue" message shouldn't be output in headless mode spec, is my understanding correct?

$ nvim -u NORC -c 'ls' --headless

  1 %a   "[No Name]"                    line 0
Press ENTER or type command to continue

glacambre · 2020-04-29T15:23:10Z

By the way, I think this "Press ENTER or type command to continue" message shouldn't be output in headless mode spec, is my understanding correct?

Yes, there's even an issue for this: #9358 :).

Code-Hex · 2020-04-29T15:37:01Z

A lot of tests have failed...
I think it's due to a lot of tests relying on headless mode. I think we need to work on replacing "Expected" and "Actual", but I can't judge if it's really correct... 😢

How should I do this?

If in headless mode, we need to exit at this point. If we continue, we will enter the normal mode and the message "Press ENTER or type command to continue" will be displayed and we will be in the input waiting state.

…ess-mode

justinmk · 2020-05-01T05:27:30Z

thanks for tracking this down!

think we need to work on replacing "Expected" and "Actual", but I can't judge if it's really correct..

where? on travis I only see this:

�[32m�[2m[ RUN      ]�[0m�[0m startup defaults :filetype late `:filetype â€¦ off` stays OFF: -- Tests exited non-zero: SIGPIPE
-- No output to stderr.
CMake Error at /home/travis/build/neovim/neovim/cmake/RunTests.cmake:85 (message):
  functional tests failed with error: SIGPIPE

justinmk · 2020-05-01T05:31:51Z

src/nvim/main.c

+    if (headless_mode) {
+      msg_putchar('\n');
+      return 0;
+    }


this probably isn't the right approach. maybe leave this for a separate PR.

headless mode should proceed through normal mode as usual, we can't assume that it should exit here. E.g. some clients may want to connect while nvim --headless runs as a server. Nvim should exit only if :q command (or equivalent) was issued.

Thanks.

I understand. I quit to touch this issue (I will focus only for “more”)

Code-Hex · 2020-05-03T08:40:01Z

@justinmk I think it was difficult. I will try to fix it

…sed" This reverts commit a02dc40.

This reverts commit 3bdb8da.

Code-Hex · 2020-05-03T10:31:42Z

@justinmk The main issue has been fixed. Re-review, please!

Code-Hex · 2020-05-03T14:29:27Z

test/functional/core/startup_spec.lua

+      -- FIXME(codehex): We should really set a timeout for the system function.
+      -- If this test fails, there will be a waiting input state.
+      funcs.system({nvim_prog, '-u', 'NONE', '-c',
+        'for i in range(1, 100) | echo i | endfor | quit',
+        '--headless'
+      })


I'm sorry, I didn't think an idea...

Code-Hex · 2020-05-06T08:59:01Z

Probably, travis CI has been broken
https://travis-ci.org/github/neovim/neovim/jobs/683712510

tjdevries

I ran this PR on my local machine and it fixed the exact problem I was having w/ headless mode pausing when I had "a lot" of output.

@justinmk I don't merge C code though as a rule ;) So it's up to you. I have no idea if this is the right fix or not given other factors.

glacambre · 2020-05-14T05:40:58Z

This PR also closes #12299, that's pretty cool!

Code-Hex · 2020-05-18T08:34:01Z

CI has been passed. (I tried force-push to rerun CI)

tjdevries · 2020-05-18T13:38:04Z

OK, I'll merge tomorrow if I don't hear any complaints. It looks good to me and is a very small change and tests pass. So seems fine to merge

Code-Hex · 2020-05-20T07:37:27Z

@tjdevries merge? 🙏

tjdevries · 2020-05-20T14:32:38Z

@Code-Hex Thanks for fixing and thanks for the ping. I actually need this for a plugin I'm working on anyway, so I can't deny some selfish motives to checking out the PR myself and running the tests ;)

* fixed hang issue with --headless and -r option specified Calling the do_more_prompt function in headless mode will freeze neovim because it is eventally in the input-accepting state (the same as waiting for --more--). * fixed "Press ENTER or type command to continue" to be suppressed If in headless mode, we need to exit at this point. If we continue, we will enter the normal mode and the message "Press ENTER or type command to continue" will be displayed and we will be in the input waiting state. * fixed functional ex_cmds tests * Revert "fixed "Press ENTER or type command to continue" to be suppressed" This reverts commit a02dc40. * Revert "fixed functional ex_cmds tests" This reverts commit 3bdb8da. * fixed conditional again * added test for fixed hang issue with --headless (neovim#11386) (cherry picked from commit c6dc397)

* fixed hang issue with --headless and -r option specified Calling the do_more_prompt function in headless mode will freeze neovim because it is eventally in the input-accepting state (the same as waiting for --more--). * fixed "Press ENTER or type command to continue" to be suppressed If in headless mode, we need to exit at this point. If we continue, we will enter the normal mode and the message "Press ENTER or type command to continue" will be displayed and we will be in the input waiting state. * fixed functional ex_cmds tests * Revert "fixed "Press ENTER or type command to continue" to be suppressed" This reverts commit a02dc40. * Revert "fixed functional ex_cmds tests" This reverts commit 3bdb8da. * fixed conditional again * added test for fixed hang issue with --headless (neovim#11386)

Maintenance release for v0.4.x series. FIXES: fd02e63 #12701 ui: fix problem with sattr_T overflow 3e3002b #12710 fs: Ensure FileInfo struct is initialized e4629f2 #12496 main.c: fix hang issue with recoverymode #12520 f558af8 #12209 fixed hang issue with --headless and -r option specified cda1190 #12180 TUI: block signals on suspend 8399f73 #12142 Fix issues revealed by gcc10 setting -fno-common by default 5e47cf2 netrw.vim: do not save +/* registers 5d41bfc #11907 quickfix.c: Fix vimgrep regression 641e229 #11903 screen: add missing redraws after a message 47bd62c loop_close: close all handles d273036 loop_close: call uv_stop(), fix bug 284b398 #11821 loop_close: timout after 2 seconds 1b2666c messages: echo "line1\r\nline2" should not clear line1 1bf90bf #11651 API: fix crash on copy_object(kObjectTypeWindow) fafd636 #11566 libcallnr: Use int, not int64_t, as the return type for Vim compat 972dd75 #11460 win_line: Fix crash with 'rightleft' in :terminal 4c48cf3 f_getenv/setenv: Access v_special when v_type is VAR_SPECIAL 2cd1ff7 #11360 paste: Select-mode, Visual-mode

NVIM v0.4.4 Maintenance release for v0.4.x series. FIXES: fd02e63 neovim#12701 ui: fix problem with sattr_T overflow 3e3002b neovim#12710 fs: Ensure FileInfo struct is initialized e4629f2 neovim#12496 main.c: fix hang issue with recoverymode neovim#12520 f558af8 neovim#12209 fixed hang issue with --headless and -r option specified cda1190 neovim#12180 TUI: block signals on suspend 8399f73 neovim#12142 Fix issues revealed by gcc10 setting -fno-common by default 5e47cf2 netrw.vim: do not save +/* registers 5d41bfc neovim#11907 quickfix.c: Fix vimgrep regression 641e229 neovim#11903 screen: add missing redraws after a message 47bd62c loop_close: close all handles d273036 loop_close: call uv_stop(), fix bug 284b398 neovim#11821 loop_close: timout after 2 seconds 1b2666c messages: echo "line1\r\nline2" should not clear line1 1bf90bf neovim#11651 API: fix crash on copy_object(kObjectTypeWindow) fafd636 neovim#11566 libcallnr: Use int, not int64_t, as the return type for Vim compat 972dd75 neovim#11460 win_line: Fix crash with 'rightleft' in :terminal 4c48cf3 f_getenv/setenv: Access v_special when v_type is VAR_SPECIAL 2cd1ff7 neovim#11360 paste: Select-mode, Visual-mode

* fixed hang issue with --headless and -r option specified Calling the do_more_prompt function in headless mode will freeze neovim because it is eventally in the input-accepting state (the same as waiting for --more--). * fixed "Press ENTER or type command to continue" to be suppressed If in headless mode, we need to exit at this point. If we continue, we will enter the normal mode and the message "Press ENTER or type command to continue" will be displayed and we will be in the input waiting state. * fixed functional ex_cmds tests * Revert "fixed "Press ENTER or type command to continue" to be suppressed" This reverts commit a02dc40. * Revert "fixed functional ex_cmds tests" This reverts commit 3bdb8da. * fixed conditional again * added test for fixed hang issue with --headless (neovim#11386)

fixed hang issue with --headless and -r option specified

acf5e3e

Calling the do_more_prompt function in headless mode will freeze neovim because it is eventally in the input-accepting state (the same as waiting for --more--).

Code-Hex added 3 commits April 30, 2020 21:41

fixed "Press ENTER or type command to continue" to be suppressed

a02dc40

If in headless mode, we need to exit at this point. If we continue, we will enter the normal mode and the message "Press ENTER or type command to continue" will be displayed and we will be in the input waiting state.

fixed functional ex_cmds tests

3bdb8da

Merge branch 'master' of github.com:neovim/neovim into fix/hang-headl…

30fdab1

…ess-mode

justinmk added this to the 0.5 milestone May 1, 2020

justinmk added the startup Nvim startup sequence (`:h startup`) label May 1, 2020

justinmk reviewed May 1, 2020

View reviewed changes

Code-Hex added 3 commits May 3, 2020 18:06

Revert "fixed "Press ENTER or type command to continue" to be suppres…

6779189

…sed" This reverts commit a02dc40.

Revert "fixed functional ex_cmds tests"

4b72b96

This reverts commit 3bdb8da.

fixed conditional again

faa34f9

Code-Hex requested a review from justinmk May 3, 2020 10:30

Code-Hex force-pushed the fix/hang-headless-mode branch from f913ef7 to baaf986 Compare May 3, 2020 14:27

Code-Hex commented May 3, 2020

View reviewed changes

Code-Hex force-pushed the fix/hang-headless-mode branch from baaf986 to ce019f2 Compare May 6, 2020 07:10

tjdevries approved these changes May 13, 2020

View reviewed changes

glacambre mentioned this pull request May 14, 2020

[Q] How do I get a list of recent files from neovim? #12299

Closed

added test for fixed hang issue with --headless (neovim#11386)

f763c8e

Code-Hex force-pushed the fix/hang-headless-mode branch from ce019f2 to f763c8e Compare May 18, 2020 07:22

tjdevries merged commit c6dc397 into neovim:master May 20, 2020

jamessan mentioned this pull request May 21, 2020

fixed hang issue with --headless and -r option specified #12352

Merged

jamessan added the maintenance:backported label May 21, 2020

Code-Hex deleted the fix/hang-headless-mode branch January 13, 2022 07:05

dundargoc removed the request for review from justinmk October 3, 2022 13:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixed hang issue with --headless and -r option specified #12209

fixed hang issue with --headless and -r option specified #12209

Code-Hex commented Apr 29, 2020 •

edited

Loading

Code-Hex commented Apr 29, 2020

glacambre commented Apr 29, 2020

Code-Hex commented Apr 29, 2020

justinmk commented May 1, 2020

justinmk May 1, 2020 •

edited

Loading

Code-Hex May 3, 2020

Code-Hex commented May 3, 2020

Code-Hex commented May 3, 2020

Code-Hex May 3, 2020

Code-Hex commented May 6, 2020

tjdevries left a comment

glacambre commented May 14, 2020

Code-Hex commented May 18, 2020

tjdevries commented May 18, 2020

Code-Hex commented May 20, 2020

tjdevries commented May 20, 2020

fixed hang issue with --headless and -r option specified #12209

fixed hang issue with --headless and -r option specified #12209

Conversation

Code-Hex commented Apr 29, 2020 • edited Loading

Code-Hex commented Apr 29, 2020

glacambre commented Apr 29, 2020

Code-Hex commented Apr 29, 2020

justinmk commented May 1, 2020

justinmk May 1, 2020 • edited Loading

Choose a reason for hiding this comment

Code-Hex May 3, 2020

Choose a reason for hiding this comment

Code-Hex commented May 3, 2020

Code-Hex commented May 3, 2020

Code-Hex May 3, 2020

Choose a reason for hiding this comment

Code-Hex commented May 6, 2020

tjdevries left a comment

Choose a reason for hiding this comment

glacambre commented May 14, 2020

Code-Hex commented May 18, 2020

tjdevries commented May 18, 2020

Code-Hex commented May 20, 2020

tjdevries commented May 20, 2020

Code-Hex commented Apr 29, 2020 •

edited

Loading

justinmk May 1, 2020 •

edited

Loading