Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: move nvim logs to XDG_CACHE_HOME #13739

Merged
merged 1 commit into from
Jan 13, 2021
Merged

logging: move nvim logs to XDG_CACHE_HOME #13739

merged 1 commit into from
Jan 13, 2021

Conversation

mjlbach
Copy link
Contributor

@mjlbach mjlbach commented Jan 12, 2021

Closes #13706

  • moves neovim's logs (including for language servers) to $XDG_CACHE_HOME

cc @teto @clason

@mjlbach mjlbach marked this pull request as draft January 12, 2021 06:46
src/nvim/os/stdpaths.c Outdated Show resolved Hide resolved
@mjlbach mjlbach changed the title logging: move to XDG_CACHE_DIR logging: move to XDG_CACHE_DIR/nvim/logs; add vim.fn.stdpath("log") Jan 12, 2021
@mjlbach mjlbach changed the title logging: move to XDG_CACHE_DIR/nvim/logs; add vim.fn.stdpath("log") logging: move nvim logs (including lsp) to XDG_CACHE_DIR/nvim/logs; add vim.fn.stdpath("log") Jan 12, 2021
@mjlbach mjlbach marked this pull request as ready for review January 12, 2021 08:52
@mjlbach

This comment has been minimized.

@mjlbach mjlbach marked this pull request as draft January 12, 2021 09:05
@mjlbach mjlbach changed the title logging: move nvim logs (including lsp) to XDG_CACHE_DIR/nvim/logs; add vim.fn.stdpath("log") logging: move nvim logs (including lsp) to XDG_CACHE_DIR/nvim Jan 12, 2021
@mjlbach mjlbach changed the title logging: move nvim logs (including lsp) to XDG_CACHE_DIR/nvim logging: move nvim logs to XDG_CACHE_HOME Jan 12, 2021
@mjlbach mjlbach changed the title logging: move nvim logs to XDG_CACHE_HOME [RDY] logging: move nvim logs to XDG_CACHE_HOME Jan 12, 2021
@mjlbach mjlbach marked this pull request as ready for review January 12, 2021 23:26
@teto teto merged commit ea8756f into neovim:master Jan 13, 2021
@teto
Copy link
Member

teto commented Jan 13, 2021

can you mention it on https://github.com/neovim/neovim/wiki/Following-HEAD please ?

@mjlbach
Copy link
Contributor Author

mjlbach commented Jan 13, 2021

Done

ckipp01 added a commit to ckipp01/vlog.nvim that referenced this pull request Jan 18, 2021
As a follow-up to the changes in neovim changing the default log
location, I figured it'd be good for this to follow suit.
neovim/neovim#13739
mikesart pushed a commit to mikesart/neovim that referenced this pull request Mar 10, 2021
while there is some controversy, stdpath('cache') looks like  a better fit for logs than stdpath('data'): you can remove logs without preventing nvim to work which fits the XDG_CACHE_HOME definition of `user specific non-essential data files`.
ckipp01 added a commit to ckipp01/plenary.nvim that referenced this pull request Apr 20, 2021
Following this in Neovim neovim/neovim#13739 it
probably makes sense to follow suit. I know this may change location for
some that are already using this, but it does seem logical to move this
here since other log files are also being placed here.
tjdevries pushed a commit to nvim-lua/plenary.nvim that referenced this pull request Apr 21, 2021
Following this in Neovim neovim/neovim#13739 it
probably makes sense to follow suit. I know this may change location for
some that are already using this, but it does seem logical to move this
here since other log files are also being placed here.
@justinmk justinmk changed the title [RDY] logging: move nvim logs to XDG_CACHE_HOME logging: move nvim logs to XDG_CACHE_HOME Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store logs in XDG_CACHE_DIR rather than XDG_DATA_HOME
2 participants