-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vim-patch:8.1.1726,8.2.{296,860,1827,2388,2788,2790,2801} #14424
Conversation
5a5d8d2
to
37fdf0a
Compare
4e488f6
to
28d948c
Compare
Problem: The eval.txt help file is too big. Solution: Split off testing support to testing.txt. Move function details to where the functionality is explained. vim/vim@ed997ad Vim commit 5477506a9f01d40fad2e8f0555bc37adee30478f contains the duplicate tag fix in runtime/doc/testing.txt.
Update runtime files vim/vim@8fe1000 Omit de.po changes. There's too many lines to port and I don't understand the language.
Updte runtime files vim/vim@589edb3 Omit state() changes in eval.txt because patch v8.1.2047 is not merged.
Update runtime files. vim/vim@5be4cee
":unset" is not a valid Ex command. Use setenv() to set/unset environment variables.
Update runtime files. vim/vim@2e693a8
Update runtime files vim/vim@96f45c0 Omit de.po changes. Same reason as before: too much and I don't understand the language.
Update runtime files. vim/vim@1ff14ba
Update runtime files vim/vim@5ef1c6a "scrollfocus" is for Windows GUI only so it is N/A.
Update runtime files vim/vim@574ee7b Omit ru.po because I don't know the language and there's too much to port.
Fix vim.desktop generation. vim/vim@1ebbb6e
Update runtime files. vim/vim@09c6f26 Omit getmousepos(). Patch v8.1.2304 is not ported yet.
Update runtime files. vim/vim@403f3eb Port sr.po changes, done by vim-patch.sh. No way I'm manually porting the rest.
Update runtime files vim/vim@0c0734d Omit rand(), srand() documentation. Patch v8.1.2342 is not ported yet.
Update runtime files. vim/vim@9135901
Update a few runtime files vim/vim@4ceaa3a Omit de.po.
Update version 8.2 notes and make syntax. vim/vim@9834b96
Update runtime files. vim/vim@c08ee74
Runtime file updates. vim/vim@664f3cf
Runtime file updates. vim/vim@32b364f
Update runtime files vim/vim@4c29502
😌 Finally done (today). Most of the runtime commits aren't complete ports but the same goes for the vim-patch PRs since vim9. Going to merge tonight (if I don't lose internet or electricity) if no one volunteers to review. It shouldn't be difficult to review if one trusts me to not mess up copy/paste when vim-patch.sh doesn't auto-apply the patch on the file. I actually messed up on some of them but all should be fixed by the last commit. Majority of the review should be spent on the runtime files, maintained by Vim, because I modified those files to omit vim9 or port to pre-8.2 Vimscript syntax (ie. rewrite method syntax to non-method syntax). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't do a thorough review, but tried to look for possible incompatibilities.
|
General question: Will we ever change
So, unless we satisfy that condition, we should be good (for now). |
Yes, when we've finished porting the 8.0 patches. |
It targets Vim 8.2 without feature and version checks.
runtime/autoload/phpcomplete.vim is reverted. win_execute PR #13664 src/nvim/testdir/test_conceal.vim passes because it doesn't run |
I'm merging this since the reviewer comments are handled here or in a separate PR (ie. win_execute). It will be at least another year before |
As for the vi_diff.txt, I'll fix it up in a separate PR. There are unmerged vim patches that shift the Vi references to vi_diff.txt |
A missing part of neovim#14424
Please report any syntax or API issues with the runtime files to their respective maintainers.
I'm going through all 70 runtime patches. Expect tons of breaking changes, at least for documentation. My aim is to port runtime patches before patch v8.2.0149 (vim9) by next week.
I'd appreciate assistance on the po files.
I haven't removed the duplicate translations yet so I expect all builds to fail.
Omit (or partially port) the following:
scrollfocus
).github/
files (ie. CODEOWNERS)20 patches done after syncing most runtime files with Vim 8.2.0.
41 patches done after syncing up before Vim 8.2.0930.
50+ to go towards Vim master.<10 left to go towards Vim master.