feat(treesitter): add q mapping to playground to close playground
#22123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theHamsta
commented
Feb 4, 2023
runtime/lua/vim/treesitter.lua
Outdated
| @@ -452,6 +452,9 @@ function M.show_tree(opts) | |||
| pg:draw(b) | |||
| end, | |||
| }) | |||
| a.nvim_buf_set_keymap(b, 'n', 'q', '<cmd>q!<cr>', { | |||
| desc = 'Close playground', | |||
There was a problem hiding this comment.
A bit unsure on how to call this playground is not shown publicly. Close tree-sitter syntax window?
There was a problem hiding this comment.
Since the map is buffer-local, I would think it should simply be "Close the current window" (or "Quit the current window"—the docs seem to use both terms interchangeably).
|
I don't think shadowing Also, is there a reason to opt for |
theHamsta
force-pushed
the
playground-quit-mapping
branch
2 times, most recently
from
8e6a59a
to
5065b86
Compare
theHamsta
force-pushed
the
playground-quit-mapping
branch
from
5065b86
to
1bbe89d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't whether this is in scope for the built-in playground, but my muscle memory always wants to use
qto close the built-in playground, because I'm used to this from other plugins to have this for these small UI helper windows.Feel free to close if not suited as a default.