[RDY] Doc cleanup (3) + terminal remnants #2532
Conversation
| URXVT: | ||
| - will get stuck if byte sequence does not contain the expected semicolon. | ||
| - Use urxvt mouse support also in xterm. Explanations: | ||
| http://www.midnight-commander.org/ticket/2662 |
There was a problem hiding this comment.
@tarruda Does nvim (or libtermkey or whatever) report mouse coordinates using the "new way" described at http://www.midnight-commander.org/ticket/2662 ? (It's a well-written ticket worth reading, could save us time)
There was a problem hiding this comment.
As far as I'm aware, yes.
ghost
mentioned this pull request
ghost
changed the title
|
This has been stagnating for a while because I haven't bothered dealing with the last commit (which was regarding 2-3 options). I've narrowed that down to just removing |
|
Fixed the merge conflict and rebased. Could you take a look at this @glts? |
|
I will after a night's rest :) |
ghost
mentioned this pull request
|
Just took a quick look. I can't really comment on this pull request as I have no idea about Neovim's tty stuff or mouse handling and I'm not in the loop about these 'terminal remnants', sorry. |
It's fine, I appreciate you taking a look anyways. @justinmk Sorry to keep doing this, but could you take a look? Not many people seem to be aware of the legacy terminal infrastructure. |
|
Added one more small commit as discussed in #2609 (comment). |
|
Fixed the merge conflict and rebased. |
|
I added more info to all the commit messages and repushed. Hopefully that makes reviewing this easier. |
| 'ttymouse' 'ttym' string (default depends on 'term') | ||
| global | ||
| {only in Unix, doesn't work in the GUI; not | ||
| available when compiled without |+mouse|} |
There was a problem hiding this comment.
This ("only on unix, not in the GUI") is a good hint that it's not an option we want to keep.
Platform-dependent features should be implemented as providers and/or passive events, possibly with lowest-common denominator support existing in the core (as is the case with TUI mouse handling).
|
LGTM, try squashing to 1 or 2 commits though. |
|
Mkay, got it from 8 to 5 commits, with the only difference in the commit messages and that example you commented on. I'll merge after the tests. |
ghost
changed the title
Regarding debugger.txt (which was Spotted by @Hettomei): The third section was empty, and the second section is very outdated. Nvim doesn't have things like Balloon Evalutation and Sun Visual workshop integration, so just remove the section. Regarding everything else: - term.[ch] and term_defs.h don't exist anymore, so remove refs to them - Add ttybuiltin to vim_diff.txt. It should have been done before, but vim_diff.txt didn't exist when ttybuiltin was removed (done in 3baba1e,) Helped-by: Justin M. Keyes <justinkz@gmail.com>
Because of 3baba1e, it's dead code. Helped-by: Justin M. Keyes <justinkz@gmail.com>
Removed in 3baba1e, but the docs weren't updated.
[RDY] Doc cleanup (3) + terminal remnants Reviewed-by: Justin M. Keyes <justinkz@gmail.com>
ghost
merged commit 
No description provided.