[RFC] Remove unused const FEAT_GUI* #2609

Hettomei · 2015-05-07T23:35:21Z

These variables are no more needed so I removed it.

And also it simplify logic for mch_errmsg and mch_msg because we can group UNIX code.

ghost · 2015-05-08T00:49:48Z

src/nvim/message.c

-    isatty(2)
-# endif
-    ) {
+  if (isatty(2)) {


Should probably use os_isatty.

You said I just have to replace every isatty with os_isatty without any other check ?

without any other check ?

What do you mean? I just mean replace the two instances of isatty in this PR with os_isatty, since they have the same semantics AFAICT:

/// Test whether a file descriptor refers to a terminal. /// /// @param fd File descriptor. /// @return `true` if file descriptor refers to a terminal. bool os_isatty(int fd) { return uv_guess_handle(fd) == UV_TTY; }

Sorry if that came across as overly blunt, I'm just trying to be clear.

By "without any other check" I mean 'I don't now what really do os_isatty instead of isatty so I asked if I really can do this without any other check.

isatty replaced in commit a083983

ghost · 2015-05-08T00:50:05Z

Besides the nit, LGTM.

yagebu · 2015-05-08T10:14:40Z

While greping the source for FEAT_GUI, I found some more unused FEAT_GUI_XYZ, that can safely be removed (namely FEAT_GUI_GTK, FEAT_GUI_MAC, FEAT_GUI_MOTIF, FEAT_GUI_MSWIN, FEAT_GUI_W32). Feel free to to remove them in this PR, or I can open a separate one if you want.

Hettomei · 2015-05-08T10:38:52Z

Thank you. I will do that in this PR as soon as possible

Hettomei · 2015-05-08T11:05:02Z

I change this PR as WIP because I found lot of const no more used and I want to clean it up.

Hettomei · 2015-05-08T13:53:52Z

I think it is good.
Off course there is other unused const but I will continue to clean these in a new PR.

Change from WIP to RFC.

ghost · 2015-05-08T20:48:42Z

Please prepend Macro cleanup: before each commit, to match previous PRs like #2011 and #1816. In repetitive PRs like this, commit names should be kept short and consistent with one another given their similarities.

ghost · 2015-05-08T20:52:22Z

runtime/doc/debugger.txt

@@ -119,7 +119,6 @@ The following compile time preprocessor variables control the features:
    Debug Glyphs				FEAT_SIGNS
    Debug Highlights				FEAT_SIGNS
    Message Footer				FEAT_FOOTER
-    Balloon Evaluation				FEAT_BEVAL


There's still a lot of references in the docs to this, but that should probably be dealt with elsewhere so I suppose it's fine.

Yes, about these const : FEAT_SIGNS, FEAT_FOOTER and FEAT_BEVAL, they only appears in this doc.

I wasn't sure if I can delete all the 2. Vim Compile Options *debugger-compilation* paragraph . Should I do this in a commit ?

I wasn't sure if I can delete all the 2. Vim Compile Options debugger-compilation paragraph . Should I do this in a commit ?

Good idea, but do you mind If instead I do that in #2532? That PR is mostly about documentation while this one already has a pretty specific focus (cleaning up macros). I'll be sure to credit your in the commit message, but it's up to you.

And if you do decide to do it here, make sure to remove section 3 as well: it's empty.

Ok, I let you do this. And don't credit me, I just revealed a probably dead doc.

And don't credit me, I just revealed a probably dead doc.

I just put spotted by @Hettomei, that's all :-)

ghost · 2015-05-08T21:08:07Z

Besides the nits on the commit structure, LGTM. Good thing you mentioned those defines.

Hettomei · 2015-05-08T22:15:48Z

I rebased on master and squashed/changed logs according to comments.

I have done a push --force is that a good way to do a PR ?

ghost · 2015-05-08T23:31:56Z

I have done a push --force is that a good way to do a PR ?

Yes, that's fine. Could you take a lot at this @mhinz and/or @splinterofchaos? I'm not 100 percent sure this code won't be needed in the future at some point.

ghost · 2015-05-09T18:31:34Z

I'll just add a waiting label so this isn't forgotten.

glts · 2015-05-09T22:47:31Z

src/nvim/menu.c

-        if (menu->children == NULL) {
-          /* found a menu item instead of a sub-menu */
-          if (*p == NUL)
-            EMSG(_("E336: Menu path must lead to a sub-menu"));


Now that message E336 is gone you can delete the E336 messages in src/nvim/po/*.po. And perhaps also the tag *E336* in runtime/doc/gui.txt.

My understanding is that they they shouldn't be deleted as they're used for generating fuzzy translations at compile time. Not completely sure though, cc @fwalch.

I was about to commit right now... I wait.

Also there is E338, and E340 (and I think many more) which is never found in source.

Yup, translations shouldn't be deleted from the PO files, even if they're unused. They might be useful for fuzzy translations.

@fwalch Didn't know that, thanks. Very sorry for the noise, @Hettomei.

Thank you for the insight.

I m newbie to C, never used po files and english is not my native language so : what concretly mean "might be useful for fuzzy translations" ?

Fuzzy translations (as opposed to "manual" translations done by a human) are automatic translations where an existing translation is used for a similar, but different message. Obviously it won't be an exact translation, hence "fuzzy".

Great, thanks @fwalch. Now that that's been sorted are you ok with this PR @glts?

@equalsraf