Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contrib): nix flake dependencies #28305

Closed
wants to merge 1 commit into from

Conversation

lxsymington
Copy link

As mentioned in this discussion:

#27294

The Nix flake build in the contrib folder is currently failing. The discussion mentions that this is likely due to an incompatible tree-sitter version. A nix flake update resolves this issue bringing in later versions of the dependencies.

For those with nix tooling this can be verified by running:

nix run 'github:neovim/neovim?dir=contrib'

where you will get the following err:

$ nix run 'github:neovim/neovim?dir=contrib'                                               
error: builder for '/nix/store/lzjc50adxxxl21kq9ysgy4sijf78r0sj-neovim-unwrapped-8cca787.drv' failed with exit code 2;
       last 10 log lines:
       > void ts_query_cursor_set_match_limit(TSQueryCursor *, uint32_t);
       >      ^
       > 1 error generated.
       > make[2]: *** [src/nvim/CMakeFiles/nvim_bin.dir/build.make:3433: src/nvim/CMakeFiles/nvim_bin.dir/lua/treesitter.c.o] Error 1
       > make[2]: *** Waiting for unfinished jobs....
       > [ 69%] Building C object src/nvim/CMakeFiles/nvim_bin.dir/map_glyph_cache.c.o
       > [ 69%] Building C object src/nvim/CMakeFiles/nvim_bin.dir/mapping.c.o
       > [ 69%] Building C object src/nvim/CMakeFiles/nvim_bin.dir/mark.c.o
       > make[1]: *** [CMakeFiles/Makefile2:624: src/nvim/CMakeFiles/nvim_bin.dir/all] Error 2
       > make: *** [Makefile:156: all] Error 2
       For full logs, run 'nix log /nix/store/lzjc50adxxxl21kq9ysgy4sijf78r0sj-neovim-unwrapped-8cca787.drv'.

Whereas running:

nix run 'github:lxsymington/neovim?dir=contrib&ref=fix/contrib/nix-flake'

will enter you into a build of neovim

@teto
Copy link
Member

teto commented Apr 12, 2024

The plan is to remove the flake from the nix repository because of the overhead it creates to contributors and move it to https://github.com/nix-community/neovim-nightly-overlay/. I haven't had the time to do so. Is this something you would be interested in ?

@justinmk justinmk added the needs:response waiting for reply from the author label Apr 14, 2024
@lxsymington
Copy link
Author

I'm pretty new to Nix so this would likely take me a bit of time. I'm interested in having a go if that's agreeable though?

@github-actions github-actions bot removed the needs:response waiting for reply from the author label Apr 15, 2024
@justinmk
Copy link
Member

Meanwhile should we merge this or not @teto ?

@justinmk justinmk added the needs:response waiting for reply from the author label Apr 15, 2024
@justinmk
Copy link
Member

merged #28394

but waiting for this to be moved to https://github.com/nix-community/neovim-nightly-overlay/ as discussed

@teto
Copy link
Member

teto commented May 1, 2024

I was on holiday sry. I will try to merge @ribru17 's flake in the nix-community overlay and once it's done I can do the announcement remove it from repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:response waiting for reply from the author platform:nix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants