build(nix): update flake to prevent build errors #28394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates nixpkgs to source a necessary Tree-sitter version - Updates to a new llvm version as the old one was removed from nixpkgs - Properly moves `doCheck` from a regular param to an attribute option
github-actions
bot
added
platform:nix
build
github-actions
bot
requested review from
dundargoc,
jamessan,
justinmk and
teto
|
I think the flake is meant to be moved anyway, so not sure changing it makes sense here? @teto |
|
see #28305 (comment) :
|
|
I made a PR to copy the flake over, once/if it gets merged I think it will be fine to remove it here, and mention that in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doCheckfrom a regular param to an attribute optionI think the documentation may still need an update, because
nix-shell '<nixpkgs>' -A neovim-unwrappedremains broken, but now the main build works as doesnix develop(which seems to give basically the same effect as the above command). Sadly I don't think I know enough about nix to provide proper documentation