[RDY] adapt to the style guildelines #371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to style guideline |
|
On Mon, Mar 17, 2014, at 08:28 PM, ZyX-I wrote:
This commit does not address all of the remaining style issues, just ~ |
|
Why not just use clang-formatter for a completely automated run? |
|
It is far from perfect. |
|
@badeip This looks good, can you rebase on top of master so I can merge? |
semi-automated harvest of low hanging fruit: change the unorthodox use of whitespace.
|
@tarruda thanks, commit rebased and amended. |
|
Merged, thanks |
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
May 25, 2015
Recent luarocks adds support for these env vars: http_proxy https_proxy no_proxy Closes neovim#2482 Changes since previous luarocks version (27 Aug 2014): git log --oneline 0587afbb5fe8ceb2f2eea16f486bd6183bf02f29..HEAD 5d8a165 Merge pull request neovim#371 from ignacio/proxies 4462ca5 Add `luarocks config` command for querying LuaRocks settings. b80244b Merge branch 'master' of https://github.com/keplerproject/luarocks dd6f0e7 Update lmathx used for testing Lua 5.3 70c7577 Merge pull request neovim#366 from Tieske/windows_exitcode 11b8b48 fixes neovim#365 0d071fa Back to scm 7bff020 Mark release 2.2.2 2f9c115 Merge branch 'master' of https://github.com/keplerproject/luarocks 9736020 Install .md files as docs 97b98bf Clip string.gsub results to just one when redacting url. 2a0a9fa Merge pull request neovim#359 from ignacio/redact_verbose 968e963 Redact api tokens when using --verbose flag 9aa5d05 Update upload URL as well. cda43ce Merge branch 'master' of https://github.com/keplerproject/luarocks 022c87d MoonRocks → LuaRocks.org transition complete! 7b6efb9 Trust the user :) 2c536b4 Deal with 'no_proxy' env var f022fe0 Drop use of config.proxy b6b6754 Merge pull request neovim#354 from Tieske/pe_parser 460e42d update to version 0.3 2ee6bd7 Merge pull request neovim#349 from ignacio/build_only_deps 15ad97b Address issues spotted in the review 6b350de Adds --only-deps flag to install command 6dd402b Adds new file (fetch/git_https.lua) to Makefile.setup.inc 46f8ad6 Merge pull request neovim#350 from jszakmeister/add-git-https-support 989347e Add git+https support. 0f67be5 Adds --only-deps flag to the 'build' command. 0fe8556 Update function documentation, as suggested by @ignacio in neovim#347. 0679559 Decided to step back in turn this into a warning. `luarocks list` on an empty ~/.luarocks is a valid use case. 40f9173 Fail when given an invalid tree. 6d5dfcd Fix crash on `luarocks --tree=/path list`. Closes neovim#347. 1fcf354 Add test that checks for error in default sysconfig. See neovim#346. 3ce554c Restore comment about second return, but put it in the right function. luarocks/luarocks#346 (comment) 0e3a052 Merge pull request neovim#346 from Tieske/bad_config c66a88e bail out on bad config files, fixes neovim#228 79addc7 Continuing slowly. Distracted by code golf. :) 58fb6b9 Merge branch 'master' of https://github.com/keplerproject/luarocks ed1f916 Starting to port test suite from Unix shell to Lua. 6f87c47 Merge pull request neovim#343 from xpol/master cbde573 And also hide the startup logo for RC. 5cb4aa7 Merge branch 'master' of https://github.com/keplerproject/luarocks 303cca7 Add AppVeyor badge ad8ba47 Merge pull request neovim#335 from ignacio/appveyor a52b5ca Merge branch 'master' of https://github.com/keplerproject/luarocks 6251735 Add Coveralls coverage badge 2fcc0cc Add options to hide the MSVC tools' startup logo. ff68e97 Fallback for platform variable e31c46b Improved the CI scripts 050d656 Fix summary detection in long paragraphs 4ad1f1a Remove failing test. Try this some other time. db81c2e Force package to be in cache. 303628a Add more simple tests. 8d6a9e3 Merge branch 'master' of https://github.com/keplerproject/luarocks 5b45de2 More small tests. 066cda4 Merge pull request neovim#341 from keplerproject/add-travis 2639401 Make localhost a known host. a549c6d Try not to block checking server identification. 7c8e527 Let's see if Travis allow sftp'ing to localhost. 98e0979 Merge branch 'master' of https://github.com/keplerproject/luarocks 5f293dd Remove debugging print. ed02691 Add trivial tests for `luarocks upload` b4ea2a1 Merge pull request neovim#340 from xpol/master b9789f3 Revert incorrect remove of cmake_generator support. Only windows (msvc) default cmake_generator are removed. a19af6d luacov-coveralls overwrites luacov.report.out! 1b5bbfc luacov-coveralls did not exit with 0? df08baf Run luacov-coveralls from $testing_dir f3aaee7 Avoid tests that mess with the testing environment. 836898f Let's try Coveralls b5244be Merge branch 'master' of https://github.com/keplerproject/luarocks 30430cf Don't overwrite --detailed when given by the user. 19ca56c Actually direct users to the bug tracker 57c838e Merge branch 'master' of https://github.com/keplerproject/luarocks 5495f3c A missing CWD returns "" for lfs.current_dir() on Ubuntu db90cb4 Really test for missing parameters. d3d74bf A missing CWD returns "" for fs.current_dir on Ubuntu... a027595 Let's try harder to fail if CWD does not exist. 876d9c8 Fix inconsistency in --homepage flag in `luarocks doc` and `luarocks write_rockspec`. 294e08f Fix --lib flag (and my last commit goof...) 62d4e05 Fix tests: new flag parser detected invalid flags in the testsuite. 7f7c006 Add support for space in long option assignments. 68aa7ae Merge branch 'master' of https://github.com/keplerproject/luarocks e869c09 Fail nicely if CWD does not exist. Fixes neovim#147. ae51a3c Fix confusing error when unpack fails due to network error 93cdd54 Adds integration with AppVeyor 28ade76 Fixes neovim#332. 51ea074 Expose platform and processor to home config files. a02a53a Merge branch 'master' of https://github.com/keplerproject/luarocks 4c96972 Don't use user tree when running as root. Fixes neovim#303. f15e49d Merge pull request neovim#330 from mpeterv/hg-support 9567ac5 Merge pull request neovim#329 from mpeterv/persist-refactor 20eb947 Improve hg support cf19178 Refactor persist.save_from_table 3c7c472 Refactor persist.load_into_table 603b0ea Merge branch 'master' of https://github.com/keplerproject/luarocks be3c52d Add extra smartness to configure to check that the user-given flag seems correct. Closes neovim#293. d820069 Merge pull request neovim#326 from mpeterv/fix-redact-api 8739847 Merge branch 'master' of https://github.com/keplerproject/luarocks 5db7c54 Merge branch 'xpol-master' 7d22ee5 Open file in 'rb 90586f6 Merge branch 'master' of https://github.com/keplerproject/luarocks bdf218b Remove commented code after remove cfg.cmake_generator. b5e2539 Better cmake support. df332f6 Fix url redacting when Luasocket is used 88a903a Add logo :) 6e21673 Try the one we have as `lua` first! 4e9a0e3 This is for Makefile.luarocks only. ccab32f Merge branch 'new-makefile' 855259b New set of Makefiles for self-upgrade. ff6fdfc Ignore more files. 92d6363 Make sure suffix is produced when installing via rock (see neovim#323) and copy over site_config.lua, in case we're installing to a different prefix (see https://sourceforge.net/p/luarocks/mailman/message/33608257/) dc5f200 Make it a bit more robust. 4347dc7 Redact API URL to hide API key. 650c8ae Back to our regularly scheduled programming 8649a4e Release LuaRocks 2.2.1 c7a704a Add test files that were not committed before. 463ee89 Don't crash when modules table is missing. d110857 Use the system-installed stat. 0f9d259 Test success of patching in `unpack`. Closes neovim#316. Includes test cases for the test suite! Yay! 9a9caf8 We're always using the internal patch module. See neovim#316. c9cc478 All 5.x versions of Lua share the same license. 92c7acb Clarify that runtime support is optional. 5f3d390 Don't crash when asking for help on invalid cmd. 46f2d25 Code cleanups suggested by luacheck. 7fe62f1 Remove unused assignment. 53e0c65 Direct users to the bug tracker 2013547 Support both --lua-version and --with-lua-version. Error messages were even already using it by accident! 48847a4 Support more file extensions as source files. 23afae6 Merge branch 'master' of https://github.com/keplerproject/luarocks c54cbfc Fix behavior of `luarocks pack` on Windows. It was failing when a path contained spaces due to lack of quoting. Closes neovim#308. 7f6320c Merge pull request neovim#309 from mpeterv/unused_variables 500741f Removed some unused and global variables 113ada0 Merge branch 'master' of https://github.com/keplerproject/luarocks 9204178 Discard excess characters when a tool gives out an octal mode string that's too long. Fixes neovim#53. aa4e0d3 Merge pull request neovim#298 from seclorum/master 9702239 Use updated LuaFileSystem for Lua 5.3 0f1c937 Updates for Lua 5.3 compatibility 8d6845e Make conversion more robust for Lua 5.3 d98c3e0 Make it more robust. (I _think_ win32 needs something similar, but there's the complication of drive letters so I won't touch it now without proper testing.) 8d588f9 Catch error if filename is a directory 1885a7f Improve error checking f74346e Do not pack scm versions cd99315 Fix search of lua interpreter. Closes neovim#301. 4c503eb Update stdlib for 5.3 (thought I had this in the previous commit!) c5501d4 Merge branch 'master' of https://github.com/keplerproject/luarocks de654b3 Updates for Lua 5.3 support 4636244 use cprint version compatible with Lua 5.3 fc6d30d Update stdlib for Lua 5.3 compatibility 76e5515 Add Lua 5.3 to the test matrix 9ab9988 Add test that catches neovim#228. 0ebdcd4 Updates to testing infrastructure (use new luasec, luacov) e7f9680 Error out on bad config files. Alternative implementation to the one given by @Tieske, following discussion in neovim#260. Closes neovim#260. Closes neovim#228. 02e8bbd Safer guards for OSX Deployment target selection.. c4558a3 OSX 10.10 Yosemite sw_vers update db46b22 Apply change suggested by @siffiejoe. Thanks @catwell for catching this! Closes neovim#295. 1a1c407 Add test for neovim#295. 8bbf02e Make test suite detect crashes on tests that should fail gracefully. 7a7c124 Add check for Fedora systems. Closes neovim#289. 723bf99 Isolate the convenience hack, for readability. a35dd43 Silence complaints from `luarocks upload`. Closes neovim#292. af679a9 Fix typo. Closes neovim#294. 453179d Provide a fallback for when the version number is 'scm', to avoid breaking Windows default paths (which assume something like c:\luarocks\2.2\ ) Closes neovim#288. 88ea74e Make code more resilient. 0467eba Merge branch 'master' of https://github.com/keplerproject/luarocks 8278ed2 Add flag to enable/disable SSL cert check. We disabled SSL certificate checks for wget and curl a while ago, when we first added https repositories. We'll keep the check disabled by default for now, but this adds a config option, `check_certificates=true` that can be used in your config.lua. af19063 Don't report WIP versions as releases. d15e99f Merge pull request neovim#285 from mpeterv/fix-lint 86ba23c Fix `luarocks lint`. e5cd7a9 Add --outdated as a flag to `luarocks list`. A variation of the feature suggested in neovim#282. f0d66ae Support per-field version checking. This will allow us to add fields and bump rockspec version numbers in a well-behaved manner.
justinmk
added a commit
that referenced
this pull request
May 28, 2015
Recent luarocks adds support for these env vars: http_proxy https_proxy no_proxy Closes #2482 Changes since previous luarocks version (27 Aug 2014): git log --oneline 0587afbb5fe8ceb2f2eea16f486bd6183bf02f29..HEAD 5d8a165 Merge pull request #371 from ignacio/proxies 4462ca5 Add `luarocks config` command for querying LuaRocks settings. b80244b Merge branch 'master' of https://github.com/keplerproject/luarocks dd6f0e7 Update lmathx used for testing Lua 5.3 70c7577 Merge pull request #366 from Tieske/windows_exitcode 11b8b48 fixes #365 0d071fa Back to scm 7bff020 Mark release 2.2.2 2f9c115 Merge branch 'master' of https://github.com/keplerproject/luarocks 9736020 Install .md files as docs 97b98bf Clip string.gsub results to just one when redacting url. 2a0a9fa Merge pull request #359 from ignacio/redact_verbose 968e963 Redact api tokens when using --verbose flag 9aa5d05 Update upload URL as well. cda43ce Merge branch 'master' of https://github.com/keplerproject/luarocks 022c87d MoonRocks → LuaRocks.org transition complete! 7b6efb9 Trust the user :) 2c536b4 Deal with 'no_proxy' env var f022fe0 Drop use of config.proxy b6b6754 Merge pull request #354 from Tieske/pe_parser 460e42d update to version 0.3 2ee6bd7 Merge pull request #349 from ignacio/build_only_deps 15ad97b Address issues spotted in the review 6b350de Adds --only-deps flag to install command 6dd402b Adds new file (fetch/git_https.lua) to Makefile.setup.inc 46f8ad6 Merge pull request #350 from jszakmeister/add-git-https-support 989347e Add git+https support. 0f67be5 Adds --only-deps flag to the 'build' command. 0fe8556 Update function documentation, as suggested by @ignacio in #347. 0679559 Decided to step back in turn this into a warning. `luarocks list` on an empty ~/.luarocks is a valid use case. 40f9173 Fail when given an invalid tree. 6d5dfcd Fix crash on `luarocks --tree=/path list`. Closes #347. 1fcf354 Add test that checks for error in default sysconfig. See #346. 3ce554c Restore comment about second return, but put it in the right function. luarocks/luarocks#346 (comment) 0e3a052 Merge pull request #346 from Tieske/bad_config c66a88e bail out on bad config files, fixes #228 79addc7 Continuing slowly. Distracted by code golf. :) 58fb6b9 Merge branch 'master' of https://github.com/keplerproject/luarocks ed1f916 Starting to port test suite from Unix shell to Lua. 6f87c47 Merge pull request #343 from xpol/master cbde573 And also hide the startup logo for RC. 5cb4aa7 Merge branch 'master' of https://github.com/keplerproject/luarocks 303cca7 Add AppVeyor badge ad8ba47 Merge pull request #335 from ignacio/appveyor a52b5ca Merge branch 'master' of https://github.com/keplerproject/luarocks 6251735 Add Coveralls coverage badge 2fcc0cc Add options to hide the MSVC tools' startup logo. ff68e97 Fallback for platform variable e31c46b Improved the CI scripts 050d656 Fix summary detection in long paragraphs 4ad1f1a Remove failing test. Try this some other time. db81c2e Force package to be in cache. 303628a Add more simple tests. 8d6a9e3 Merge branch 'master' of https://github.com/keplerproject/luarocks 5b45de2 More small tests. 066cda4 Merge pull request #341 from keplerproject/add-travis 2639401 Make localhost a known host. a549c6d Try not to block checking server identification. 7c8e527 Let's see if Travis allow sftp'ing to localhost. 98e0979 Merge branch 'master' of https://github.com/keplerproject/luarocks 5f293dd Remove debugging print. ed02691 Add trivial tests for `luarocks upload` b4ea2a1 Merge pull request #340 from xpol/master b9789f3 Revert incorrect remove of cmake_generator support. Only windows (msvc) default cmake_generator are removed. a19af6d luacov-coveralls overwrites luacov.report.out! 1b5bbfc luacov-coveralls did not exit with 0? df08baf Run luacov-coveralls from $testing_dir f3aaee7 Avoid tests that mess with the testing environment. 836898f Let's try Coveralls b5244be Merge branch 'master' of https://github.com/keplerproject/luarocks 30430cf Don't overwrite --detailed when given by the user. 19ca56c Actually direct users to the bug tracker 57c838e Merge branch 'master' of https://github.com/keplerproject/luarocks 5495f3c A missing CWD returns "" for lfs.current_dir() on Ubuntu db90cb4 Really test for missing parameters. d3d74bf A missing CWD returns "" for fs.current_dir on Ubuntu... a027595 Let's try harder to fail if CWD does not exist. 876d9c8 Fix inconsistency in --homepage flag in `luarocks doc` and `luarocks write_rockspec`. 294e08f Fix --lib flag (and my last commit goof...) 62d4e05 Fix tests: new flag parser detected invalid flags in the testsuite. 7f7c006 Add support for space in long option assignments. 68aa7ae Merge branch 'master' of https://github.com/keplerproject/luarocks e869c09 Fail nicely if CWD does not exist. Fixes #147. ae51a3c Fix confusing error when unpack fails due to network error 93cdd54 Adds integration with AppVeyor 28ade76 Fixes #332. 51ea074 Expose platform and processor to home config files. a02a53a Merge branch 'master' of https://github.com/keplerproject/luarocks 4c96972 Don't use user tree when running as root. Fixes #303. f15e49d Merge pull request #330 from mpeterv/hg-support 9567ac5 Merge pull request #329 from mpeterv/persist-refactor 20eb947 Improve hg support cf19178 Refactor persist.save_from_table 3c7c472 Refactor persist.load_into_table 603b0ea Merge branch 'master' of https://github.com/keplerproject/luarocks be3c52d Add extra smartness to configure to check that the user-given flag seems correct. Closes #293. d820069 Merge pull request #326 from mpeterv/fix-redact-api 8739847 Merge branch 'master' of https://github.com/keplerproject/luarocks 5db7c54 Merge branch 'xpol-master' 7d22ee5 Open file in 'rb 90586f6 Merge branch 'master' of https://github.com/keplerproject/luarocks bdf218b Remove commented code after remove cfg.cmake_generator. b5e2539 Better cmake support. df332f6 Fix url redacting when Luasocket is used 88a903a Add logo :) 6e21673 Try the one we have as `lua` first! 4e9a0e3 This is for Makefile.luarocks only. ccab32f Merge branch 'new-makefile' 855259b New set of Makefiles for self-upgrade. ff6fdfc Ignore more files. 92d6363 Make sure suffix is produced when installing via rock (see #323) and copy over site_config.lua, in case we're installing to a different prefix (see https://sourceforge.net/p/luarocks/mailman/message/33608257/) dc5f200 Make it a bit more robust. 4347dc7 Redact API URL to hide API key. 650c8ae Back to our regularly scheduled programming 8649a4e Release LuaRocks 2.2.1 c7a704a Add test files that were not committed before. 463ee89 Don't crash when modules table is missing. d110857 Use the system-installed stat. 0f9d259 Test success of patching in `unpack`. Closes #316. Includes test cases for the test suite! Yay! 9a9caf8 We're always using the internal patch module. See #316. c9cc478 All 5.x versions of Lua share the same license. 92c7acb Clarify that runtime support is optional. 5f3d390 Don't crash when asking for help on invalid cmd. 46f2d25 Code cleanups suggested by luacheck. 7fe62f1 Remove unused assignment. 53e0c65 Direct users to the bug tracker 2013547 Support both --lua-version and --with-lua-version. Error messages were even already using it by accident! 48847a4 Support more file extensions as source files. 23afae6 Merge branch 'master' of https://github.com/keplerproject/luarocks c54cbfc Fix behavior of `luarocks pack` on Windows. It was failing when a path contained spaces due to lack of quoting. Closes #308. 7f6320c Merge pull request #309 from mpeterv/unused_variables 500741f Removed some unused and global variables 113ada0 Merge branch 'master' of https://github.com/keplerproject/luarocks 9204178 Discard excess characters when a tool gives out an octal mode string that's too long. Fixes #53. aa4e0d3 Merge pull request #298 from seclorum/master 9702239 Use updated LuaFileSystem for Lua 5.3 0f1c937 Updates for Lua 5.3 compatibility 8d6845e Make conversion more robust for Lua 5.3 d98c3e0 Make it more robust. (I _think_ win32 needs something similar, but there's the complication of drive letters so I won't touch it now without proper testing.) 8d588f9 Catch error if filename is a directory 1885a7f Improve error checking f74346e Do not pack scm versions cd99315 Fix search of lua interpreter. Closes #301. 4c503eb Update stdlib for 5.3 (thought I had this in the previous commit!) c5501d4 Merge branch 'master' of https://github.com/keplerproject/luarocks de654b3 Updates for Lua 5.3 support 4636244 use cprint version compatible with Lua 5.3 fc6d30d Update stdlib for Lua 5.3 compatibility 76e5515 Add Lua 5.3 to the test matrix 9ab9988 Add test that catches #228. 0ebdcd4 Updates to testing infrastructure (use new luasec, luacov) e7f9680 Error out on bad config files. Alternative implementation to the one given by @Tieske, following discussion in #260. Closes #260. Closes #228. 02e8bbd Safer guards for OSX Deployment target selection.. c4558a3 OSX 10.10 Yosemite sw_vers update db46b22 Apply change suggested by @siffiejoe. Thanks @catwell for catching this! Closes #295. 1a1c407 Add test for #295. 8bbf02e Make test suite detect crashes on tests that should fail gracefully. 7a7c124 Add check for Fedora systems. Closes #289. 723bf99 Isolate the convenience hack, for readability. a35dd43 Silence complaints from `luarocks upload`. Closes #292. af679a9 Fix typo. Closes #294. 453179d Provide a fallback for when the version number is 'scm', to avoid breaking Windows default paths (which assume something like c:\luarocks\2.2\ ) Closes #288. 88ea74e Make code more resilient. 0467eba Merge branch 'master' of https://github.com/keplerproject/luarocks 8278ed2 Add flag to enable/disable SSL cert check. We disabled SSL certificate checks for wget and curl a while ago, when we first added https repositories. We'll keep the check disabled by default for now, but this adds a config option, `check_certificates=true` that can be used in your config.lua. af19063 Don't report WIP versions as releases. d15e99f Merge pull request #285 from mpeterv/fix-lint 86ba23c Fix `luarocks lint`. e5cd7a9 Add --outdated as a flag to `luarocks list`. A variation of the feature suggested in #282. f0d66ae Support per-field version checking. This will allow us to add fields and bump rockspec version numbers in a well-behaved manner.
aktau
added a commit
to aktau/neovim
that referenced
this pull request
Jun 24, 2022
Problem ------- In neovim#19040, I reported two things that started happening somewhen in the last three months when using neovim in hterm (the Chrome Secure Shell terminal): 1. Under certain circumstances, the window title (set by nvim [i0]) would appear over the line I was typing, corrupting the screen. 2. If I changed my $TERM from xterm-256color to the new hterm-256color (available since ncurses >=20210320), the window title corruption was gone, but pane scrolling was broken. Both problems are due to changes in the termcap files, their source of truth being the ncurses project. See "Timeline of ncurses changes" below for details. Cause: title corruption ----------------------- The title corruption when using hterm + TERM=xterm-256color can be explained by event neovim#4 (ncurses 2022-03-12) in the ncurses timeline: The xterm-256color termcap file gained status line termcodes in ncurses 2022-03-12. These termcodes are used by Neovim to set the title when. hterm does not have a status line. Due to ncurses versions earlier than 2022-03-12 missing the xterm status line capability, Neovim manually fixed up [t0] the terminfo file if $TERM was xterm-256color. So if before Neovim manually added fsl/tsl capabilties, and after they were in the termcap file, why did hterm suddenly start getting corruption? The answer is that the termcodes for these capabilties are different when Neovim fixes them up, versus the one in the new termcap database: fsl=\E[0$} // from xterm-256color tsl=\E[2$~\E[1$}\E[%i%p1%d` // from xterm-256color fsl=\x07 // patched by Neovim tsl=\x1b]0; // patched by Neovim hterm ignores the latter, but corrupts the screen with the former. Solution: Make hterm users set hterm-256color, which lacks the new fsl/tsl codes. Also, to reduce superfluous work, stop patching in this capability when hterm is detected (even if hterm would ignore the patched version). Cause: pane corruption ---------------------- The pane corruption when using hterm + TERM=hterm-256color, but NOT when using hterm + TERM=xterm-256color can be explained by: - Neovim uses DECSLRM when available [p1] for performant scrolling. - Both the hterm-256color and xterm-256color termcap databases advertise support for DECSLRM (ncurses timeline #1, neovim#2 and neovim#3). - hterm does not support DESCLRM [p2] (note: it does support DESCTBM for top/bottom scrolling, but it's broken [p3] and not used by Neovim) - xterm-alikes that are not real xterm generally don't support DECSLRM either, so Neovim patches it out [p4]. When using hterm-256color, hterm is no longer considered an xterm-alike by Neovim. As a result, DECSLRM is not cleared. hterm does not support it, so corruption ensues. This is a problem with the hterm-256color termcap file, but we're stuck with it so the best we can do is patch over it. Timeline of ncurses changes --------------------------- 1. 2019-05-19: Part of the DECSLRM capability (smglr AKA set_lr_margin) added to vt420+lrmm, which xterm-256color inherits [n1] 2. 2021-03-20: hterm-256color added, inheriting xterm-256colors. [n2] 3. 2021-09-25: The *parm versions of smglr (AKA set_lr_margin) were added to vt420+lrmm [n3]. Namely: 1. smglp AKA set_left_margin_parm, and 2. smgrp AKA set_right_margin_parm 4. 2022-03-12: (new) codes for fsl, bsl and tsl added to xterm (add dec+sl to xterm-new, per patch neovim#371 -TD) [n4] Fixes neovim#19040. [i0]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1377 [t0]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1728,L1729 [p1]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1196 [p2]: https://bugs.chromium.org/p/chromium/issues/detail?id=1175065&q=component%3APlatform%3EApps%3EDefault%3EHterm [p3]: https://bugs.chromium.org/p/chromium/issues/detail?id=1298796&q=component%3APlatform%3EApps%3EDefault%3EHterm [p4]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1740-L1752 [n1]: mirror/ncurses@8f6d94b#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R2742 [n2]: mirror/ncurses@c265010#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R5907 [n3]: mirror/ncurses@f6b436c#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R2842 [n4]: mirror/ncurses@8bf8c83#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R4828 Signed-off-by: Nicolas Hillegeer <nicolas@hillegeer.com>
aktau
added a commit
to aktau/neovim
that referenced
this pull request
Jun 26, 2022
Problem ------- In neovim#19040, I reported two things that started happening somewhen in the last three months when using neovim in hterm (the Chrome Secure Shell terminal): 1. Under certain circumstances, the window title (set by nvim [i0]) would appear over the line I was typing, corrupting the screen. 2. If I changed my $TERM from xterm-256color to the new hterm-256color (available since ncurses >=20210320), the window title corruption was gone, but pane scrolling was broken. Both problems are due to changes in the termcap files, their source of truth being the ncurses project. See "Timeline of ncurses changes" below for details. Cause: title corruption ----------------------- The title corruption when using hterm + TERM=xterm-256color can be explained by event neovim#4 (ncurses 2022-03-12) in the ncurses timeline: The xterm-256color termcap file gained status line termcodes in ncurses 2022-03-12. These termcodes are used by Neovim to set the title when. hterm does not have a status line. Due to ncurses versions earlier than 2022-03-12 missing the xterm status line capability, Neovim manually fixed up [t0] the terminfo file if $TERM was xterm-256color. So if before Neovim manually added fsl/tsl capabilties, and after they were in the termcap file, why did hterm suddenly start getting corruption? The answer is that the termcodes for these capabilties are different when Neovim fixes them up, versus the one in the new termcap database: fsl=\E[0$} // from xterm-256color tsl=\E[2$~\E[1$}\E[%i%p1%d` // from xterm-256color fsl=\x07 // patched by Neovim tsl=\x1b]0; // patched by Neovim hterm ignores the latter, but corrupts the screen with the former. Solution: Make hterm users set hterm-256color, which lacks the new fsl/tsl codes. Also, to reduce superfluous work, stop patching in this capability when hterm is detected (even if hterm would ignore the patched version). Cause: pane corruption ---------------------- The pane corruption when using hterm + TERM=hterm-256color, but NOT when using hterm + TERM=xterm-256color can be explained by: - Neovim uses DECSLRM when available [p1] for performant scrolling. - Both the hterm-256color and xterm-256color termcap databases advertise support for DECSLRM (ncurses timeline #1, neovim#2 and neovim#3). - hterm does not support DESCLRM [p2] (note: it does support DESCTBM for top/bottom scrolling, but it's broken [p3] and not used by Neovim) - xterm-alikes that are not real xterm generally don't support DECSLRM either, so Neovim patches it out [p4]. When using hterm-256color, hterm is no longer considered an xterm-alike by Neovim. As a result, DECSLRM is not cleared. hterm does not support it, so corruption ensues. This is a problem with the hterm-256color termcap file, but we're stuck with it so the best we can do is patch over it. Timeline of ncurses changes --------------------------- 1. 2019-05-19: Part of the DECSLRM capability (smglr AKA set_lr_margin) added to vt420+lrmm, which xterm-256color inherits [n1] 2. 2021-03-20: hterm-256color added, inheriting xterm-256colors. [n2] 3. 2021-09-25: The *parm versions of smglr (AKA set_lr_margin) were added to vt420+lrmm [n3]. Namely: 1. smglp AKA set_left_margin_parm, and 2. smgrp AKA set_right_margin_parm 4. 2022-03-12: (new) codes for fsl, bsl and tsl added to xterm (add dec+sl to xterm-new, per patch neovim#371 -TD) [n4] Fixes neovim#19040. [i0]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1377 [t0]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1728,L1729 [p1]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1196 [p2]: https://bugs.chromium.org/p/chromium/issues/detail?id=1175065&q=component%3APlatform%3EApps%3EDefault%3EHterm [p3]: https://bugs.chromium.org/p/chromium/issues/detail?id=1298796&q=component%3APlatform%3EApps%3EDefault%3EHterm [p4]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1740-L1752 [n1]: mirror/ncurses@8f6d94b#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R2742 [n2]: mirror/ncurses@c265010#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R5907 [n3]: mirror/ncurses@f6b436c#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R2842 [n4]: mirror/ncurses@8bf8c83#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R4828 Signed-off-by: Nicolas Hillegeer <nicolas@hillegeer.com>
aktau
added a commit
to aktau/neovim
that referenced
this pull request
Jun 27, 2022
Problem ------- In neovim#19040, I reported two things that started happening somewhen in the last three months when using neovim in hterm (the Chrome Secure Shell terminal): 1. Under certain circumstances, the window title (set by nvim [i0]) would appear over the line I was typing, corrupting the screen. 2. If I changed my $TERM from xterm-256color to the new hterm-256color (available since ncurses >=20210320), the window title corruption was gone, but pane scrolling was broken. Both problems are due to changes in the termcap files, their source of truth being the ncurses project. See "Timeline of ncurses changes" below for details. Cause: title corruption ----------------------- The title corruption when using hterm + TERM=xterm-256color can be explained by event neovim#4 (ncurses 2022-03-12) in the ncurses timeline: The xterm-256color termcap file gained status line termcodes in ncurses 2022-03-12. These termcodes are used by Neovim to set the title when. hterm does not have a status line. Due to ncurses versions earlier than 2022-03-12 missing the xterm status line capability, Neovim manually fixed up [t0] the terminfo file if $TERM was xterm-256color. So if before Neovim manually added fsl/tsl capabilties, and after they were in the termcap file, why did hterm suddenly start getting corruption? The answer is that the termcodes for these capabilties are different when Neovim fixes them up, versus the one in the new termcap database: fsl=\E[0$} // from xterm-256color tsl=\E[2$~\E[1$}\E[%i%p1%d` // from xterm-256color fsl=\x07 // patched by Neovim tsl=\x1b]0; // patched by Neovim hterm ignores the latter, but corrupts the screen with the former. Solution: Make hterm users set hterm-256color, which lacks the new fsl/tsl codes. Also, to reduce superfluous work, stop patching in this capability when hterm is detected (even if hterm would ignore the patched version). Cause: pane corruption ---------------------- The pane corruption when using hterm + TERM=hterm-256color, but NOT when using hterm + TERM=xterm-256color can be explained by: - Neovim uses DECSLRM when available [p1] for performant scrolling. - Both the hterm-256color and xterm-256color termcap databases advertise support for DECSLRM (ncurses timeline #1, neovim#2 and neovim#3). - hterm does not support DESCLRM [p2] (note: it does support DESCTBM for top/bottom scrolling, but it's broken [p3] and not used by Neovim) - xterm-alikes that are not real xterm generally don't support DECSLRM either, so Neovim patches it out [p4]. When using hterm-256color, hterm is no longer considered an xterm-alike by Neovim. As a result, DECSLRM is not cleared. hterm does not support it, so corruption ensues. This is a problem with the hterm-256color termcap file, but we're stuck with it so the best we can do is patch over it. Timeline of ncurses changes --------------------------- 1. 2019-05-19: Part of the DECSLRM capability (smglr AKA set_lr_margin) added to vt420+lrmm, which xterm-256color inherits [n1] 2. 2021-03-20: hterm-256color added, inheriting xterm-256colors. [n2] 3. 2021-09-25: The *parm versions of smglr (AKA set_lr_margin) were added to vt420+lrmm [n3]. Namely: 1. smglp AKA set_left_margin_parm, and 2. smgrp AKA set_right_margin_parm 4. 2022-03-12: (new) codes for fsl, bsl and tsl added to xterm (add dec+sl to xterm-new, per patch neovim#371 -TD) [n4] Fixes neovim#19040. [i0]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1377 [t0]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1728,L1729 [p1]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1196 [p2]: https://bugs.chromium.org/p/chromium/issues/detail?id=1175065&q=component%3APlatform%3EApps%3EDefault%3EHterm [p3]: https://bugs.chromium.org/p/chromium/issues/detail?id=1298796&q=component%3APlatform%3EApps%3EDefault%3EHterm [p4]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1740-L1752 [n1]: mirror/ncurses@8f6d94b#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R2742 [n2]: mirror/ncurses@c265010#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R5907 [n3]: mirror/ncurses@f6b436c#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R2842 [n4]: mirror/ncurses@8bf8c83#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R4828 Signed-off-by: Nicolas Hillegeer <nicolas@hillegeer.com>
aktau
added a commit
to aktau/neovim
that referenced
this pull request
Jul 8, 2022
Problem ------- In neovim#19040, I reported two things that started happening somewhen in the last three months when using neovim in hterm (the Chrome Secure Shell terminal): 1. Under certain circumstances, the window title (set by nvim [i0]) would appear over the line I was typing, corrupting the screen. 2. If I changed my $TERM from xterm-256color to the new hterm-256color (available since ncurses >=20210320), the window title corruption was gone, but pane scrolling was broken. Both problems are due to changes in the termcap files, their source of truth being the ncurses project. See "Timeline of ncurses changes" below for details. Cause: title corruption ----------------------- The title corruption when using hterm + TERM=xterm-256color can be explained by event neovim#4 (ncurses 2022-03-12) in the ncurses timeline: The xterm-256color termcap file gained status line termcodes in ncurses 2022-03-12. These termcodes are used by Neovim to set the title when. hterm does not have a status line. Due to ncurses versions earlier than 2022-03-12 missing the xterm status line capability, Neovim manually fixed up [t0] the terminfo file if $TERM was xterm-256color. So if before Neovim manually added fsl/tsl capabilties, and after they were in the termcap file, why did hterm suddenly start getting corruption? The answer is that the termcodes for these capabilties are different when Neovim fixes them up, versus the one in the new termcap database: fsl=\E[0$} // from xterm-256color tsl=\E[2$~\E[1$}\E[%i%p1%d` // from xterm-256color fsl=\x07 // patched by Neovim tsl=\x1b]0; // patched by Neovim hterm ignores the latter, but corrupts the screen with the former. Solution: Make hterm users set hterm-256color, which lacks the new fsl/tsl codes. Also, to reduce superfluous work, stop patching in this capability when hterm is detected (even if hterm would ignore the patched version). Cause: pane corruption ---------------------- The pane corruption when using hterm + TERM=hterm-256color, but NOT when using hterm + TERM=xterm-256color can be explained by: - Neovim uses DECSLRM when available [p1] for performant scrolling. - Both the hterm-256color and xterm-256color termcap databases advertise support for DECSLRM (ncurses timeline #1, neovim#2 and neovim#3). - hterm does not support DESCLRM [p2] (note: it does support DESCTBM for top/bottom scrolling, but it's broken [p3] and not used by Neovim) - xterm-alikes that are not real xterm generally don't support DECSLRM either, so Neovim patches it out [p4]. When using hterm-256color, hterm is no longer considered an xterm-alike by Neovim. As a result, DECSLRM is not cleared. hterm does not support it, so corruption ensues. This is a problem with the hterm-256color termcap file, but we're stuck with it so the best we can do is patch over it. Timeline of ncurses changes --------------------------- 1. 2019-05-19: Part of the DECSLRM capability (smglr AKA set_lr_margin) added to vt420+lrmm, which xterm-256color inherits [n1] 2. 2021-03-20: hterm-256color added, inheriting xterm-256colors. [n2] 3. 2021-09-25: The *parm versions of smglr (AKA set_lr_margin) were added to vt420+lrmm [n3]. Namely: 1. smglp AKA set_left_margin_parm, and 2. smgrp AKA set_right_margin_parm 4. 2022-03-12: (new) codes for fsl, bsl and tsl added to xterm (add dec+sl to xterm-new, per patch neovim#371 -TD) [n4] Fixes neovim#19040. [i0]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1377 [t0]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1728,L1729 [p1]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1196 [p2]: https://bugs.chromium.org/p/chromium/issues/detail?id=1175065&q=component%3APlatform%3EApps%3EDefault%3EHterm [p3]: https://bugs.chromium.org/p/chromium/issues/detail?id=1298796&q=component%3APlatform%3EApps%3EDefault%3EHterm [p4]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1740-L1752 [n1]: mirror/ncurses@8f6d94b#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R2742 [n2]: mirror/ncurses@c265010#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R5907 [n3]: mirror/ncurses@f6b436c#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R2842 [n4]: mirror/ncurses@8bf8c83#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R4828 Signed-off-by: Nicolas Hillegeer <nicolas@hillegeer.com>
justinmk
pushed a commit
that referenced
this pull request
Jul 8, 2022
Problem ------- In #19040, I reported two things that started happening somewhen in the last three months when using neovim in hterm (the Chrome Secure Shell terminal): 1. Under certain circumstances, the window title (set by nvim [i0]) would appear over the line I was typing, corrupting the screen. 2. If I changed my $TERM from xterm-256color to the new hterm-256color (available since ncurses >=20210320), the window title corruption was gone, but pane scrolling was broken. Both problems are due to changes in the termcap files, their source of truth being the ncurses project. See "Timeline of ncurses changes" below for details. Cause: title corruption ----------------------- The title corruption when using hterm + TERM=xterm-256color can be explained by event #4 (ncurses 2022-03-12) in the ncurses timeline: The xterm-256color termcap file gained status line termcodes in ncurses 2022-03-12. These termcodes are used by Neovim to set the title when. hterm does not have a status line. Due to ncurses versions earlier than 2022-03-12 missing the xterm status line capability, Neovim manually fixed up [t0] the terminfo file if $TERM was xterm-256color. So if before Neovim manually added fsl/tsl capabilties, and after they were in the termcap file, why did hterm suddenly start getting corruption? The answer is that the termcodes for these capabilties are different when Neovim fixes them up, versus the one in the new termcap database: fsl=\E[0$} // from xterm-256color tsl=\E[2$~\E[1$}\E[%i%p1%d` // from xterm-256color fsl=\x07 // patched by Neovim tsl=\x1b]0; // patched by Neovim hterm ignores the latter, but corrupts the screen with the former. Solution: Make hterm users set hterm-256color, which lacks the new fsl/tsl codes. Also, to reduce superfluous work, stop patching in this capability when hterm is detected (even if hterm would ignore the patched version). Cause: pane corruption ---------------------- The pane corruption when using hterm + TERM=hterm-256color, but NOT when using hterm + TERM=xterm-256color can be explained by: - Neovim uses DECSLRM when available [p1] for performant scrolling. - Both the hterm-256color and xterm-256color termcap databases advertise support for DECSLRM (ncurses timeline #1, #2 and #3). - hterm does not support DESCLRM [p2] (note: it does support DESCTBM for top/bottom scrolling, but it's broken [p3] and not used by Neovim) - xterm-alikes that are not real xterm generally don't support DECSLRM either, so Neovim patches it out [p4]. When using hterm-256color, hterm is no longer considered an xterm-alike by Neovim. As a result, DECSLRM is not cleared. hterm does not support it, so corruption ensues. This is a problem with the hterm-256color termcap file, but we're stuck with it so the best we can do is patch over it. Timeline of ncurses changes --------------------------- 1. 2019-05-19: Part of the DECSLRM capability (smglr AKA set_lr_margin) added to vt420+lrmm, which xterm-256color inherits [n1] 2. 2021-03-20: hterm-256color added, inheriting xterm-256colors. [n2] 3. 2021-09-25: The *parm versions of smglr (AKA set_lr_margin) were added to vt420+lrmm [n3]. Namely: 1. smglp AKA set_left_margin_parm, and 2. smgrp AKA set_right_margin_parm 4. 2022-03-12: (new) codes for fsl, bsl and tsl added to xterm (add dec+sl to xterm-new, per patch #371 -TD) [n4] Fixes #19040. [i0]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1377 [t0]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1728,L1729 [p1]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1196 [p2]: https://bugs.chromium.org/p/chromium/issues/detail?id=1175065&q=component%3APlatform%3EApps%3EDefault%3EHterm [p3]: https://bugs.chromium.org/p/chromium/issues/detail?id=1298796&q=component%3APlatform%3EApps%3EDefault%3EHterm [p4]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1740-L1752 [n1]: mirror/ncurses@8f6d94b#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R2742 [n2]: mirror/ncurses@c265010#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R5907 [n3]: mirror/ncurses@f6b436c#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R2842 [n4]: mirror/ncurses@8bf8c83#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R4828 Signed-off-by: Nicolas Hillegeer <nicolas@hillegeer.com>
smjonas
pushed a commit
to smjonas/neovim
that referenced
this pull request
Dec 31, 2022
Problem ------- In neovim#19040, I reported two things that started happening somewhen in the last three months when using neovim in hterm (the Chrome Secure Shell terminal): 1. Under certain circumstances, the window title (set by nvim [i0]) would appear over the line I was typing, corrupting the screen. 2. If I changed my $TERM from xterm-256color to the new hterm-256color (available since ncurses >=20210320), the window title corruption was gone, but pane scrolling was broken. Both problems are due to changes in the termcap files, their source of truth being the ncurses project. See "Timeline of ncurses changes" below for details. Cause: title corruption ----------------------- The title corruption when using hterm + TERM=xterm-256color can be explained by event neovim#4 (ncurses 2022-03-12) in the ncurses timeline: The xterm-256color termcap file gained status line termcodes in ncurses 2022-03-12. These termcodes are used by Neovim to set the title when. hterm does not have a status line. Due to ncurses versions earlier than 2022-03-12 missing the xterm status line capability, Neovim manually fixed up [t0] the terminfo file if $TERM was xterm-256color. So if before Neovim manually added fsl/tsl capabilties, and after they were in the termcap file, why did hterm suddenly start getting corruption? The answer is that the termcodes for these capabilties are different when Neovim fixes them up, versus the one in the new termcap database: fsl=\E[0$} // from xterm-256color tsl=\E[2$~\E[1$}\E[%i%p1%d` // from xterm-256color fsl=\x07 // patched by Neovim tsl=\x1b]0; // patched by Neovim hterm ignores the latter, but corrupts the screen with the former. Solution: Make hterm users set hterm-256color, which lacks the new fsl/tsl codes. Also, to reduce superfluous work, stop patching in this capability when hterm is detected (even if hterm would ignore the patched version). Cause: pane corruption ---------------------- The pane corruption when using hterm + TERM=hterm-256color, but NOT when using hterm + TERM=xterm-256color can be explained by: - Neovim uses DECSLRM when available [p1] for performant scrolling. - Both the hterm-256color and xterm-256color termcap databases advertise support for DECSLRM (ncurses timeline neovim#1, neovim#2 and neovim#3). - hterm does not support DESCLRM [p2] (note: it does support DESCTBM for top/bottom scrolling, but it's broken [p3] and not used by Neovim) - xterm-alikes that are not real xterm generally don't support DECSLRM either, so Neovim patches it out [p4]. When using hterm-256color, hterm is no longer considered an xterm-alike by Neovim. As a result, DECSLRM is not cleared. hterm does not support it, so corruption ensues. This is a problem with the hterm-256color termcap file, but we're stuck with it so the best we can do is patch over it. Timeline of ncurses changes --------------------------- 1. 2019-05-19: Part of the DECSLRM capability (smglr AKA set_lr_margin) added to vt420+lrmm, which xterm-256color inherits [n1] 2. 2021-03-20: hterm-256color added, inheriting xterm-256colors. [n2] 3. 2021-09-25: The *parm versions of smglr (AKA set_lr_margin) were added to vt420+lrmm [n3]. Namely: 1. smglp AKA set_left_margin_parm, and 2. smgrp AKA set_right_margin_parm 4. 2022-03-12: (new) codes for fsl, bsl and tsl added to xterm (add dec+sl to xterm-new, per patch neovim#371 -TD) [n4] Fixes neovim#19040. [i0]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1377 [t0]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1728,L1729 [p1]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1196 [p2]: https://bugs.chromium.org/p/chromium/issues/detail?id=1175065&q=component%3APlatform%3EApps%3EDefault%3EHterm [p3]: https://bugs.chromium.org/p/chromium/issues/detail?id=1298796&q=component%3APlatform%3EApps%3EDefault%3EHterm [p4]: https://github.com/neovim/neovim/blob/3a4fa22badc5595afc0a994ead965ff32ccf6c76/src/nvim/tui/tui.c#L1740-L1752 [n1]: mirror/ncurses@8f6d94b#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R2742 [n2]: mirror/ncurses@c265010#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R5907 [n3]: mirror/ncurses@f6b436c#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R2842 [n4]: mirror/ncurses@8bf8c83#diff-01544c577762d3308a1d232aa7afc79acf64b9a5057f88a004df82fda89549b7R4828 Signed-off-by: Nicolas Hillegeer <nicolas@hillegeer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
semi-automated harvest of low hanging fruit:
change the unorthodox use of whitespace.
brace for function declarations on separate line