[RFC] vim-patch:8.0.0308,8.0.0325,8.0.0326,8.0.0437,8.0.0612,8.0.0680 #7201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
reviewed
Aug 21, 2017
src/nvim/main.c
Outdated
| add_pack_start_dirs(); | ||
| } | ||
|
|
||
| source_runtime((char_u *)"plugin/**/*.vim", DIP_ALL | DIP_NOAFTER); // NOLINT | ||
| source_in_path(rtp_copy, (char_u *)"plugin/**/*.vim", // NOLINT |
There was a problem hiding this comment.
the vim patch does rtp_copy == NULL ? p_rtp : rtp_copy
There was a problem hiding this comment.
Vim checks for NULL, we don't. vim_strsave is a very thin wrapper around xstrdup for us, mainly handling casting.
There was a problem hiding this comment.
yes, but isn't it possible that rtp_copy is null if the condition on line 1301 is false? Even if it's not possible because of "action at a distance", I would tend to prefer the localized guard which removes all doubt.
Problem: When using a symbolic link, the package path will not be inserted
at the right position in 'runtimepath'. (Dugan Chen, Norio Takagi)
Solution: Resolve symbolic links when finding the right position in
'runtimepath'. (Hirohito Higashi)
vim/vim@2f9e575
Problem: Packadd test does not clean up symlink. Solution: Delete the link. (Hirohito Higashi) vim/vim@913727e
Problem: Packadd test uses wrong directory name. Solution: Use the variable name value. (Hirohito Higashi) vim/vim@24f8f54
Problem: The packadd test does not create the symlink correctly and does
not test the right thing.
Solution: Create the directory and symlink correctly.
vim/vim@644df41
Problem: Package directories are added to 'runtimepath' only after loading
non-package plugins.
Solution: Split off the code to add package directories to 'runtimepath'.
(Ingo Karkat, closes vim/vim#1680)
vim/vim@ce876aa
Problem: Plugins in start packages are sourced twice. (mseplowitz)
Solution: Use the unmodified runtime path when loading plugins (test by Ingo
Karkat, closes vim/vim#1801)
vim/vim@07ecfa6
justinmk
approved these changes
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vim-patch:8.0.0308
Problem: When using a symbolic link, the package path will not be inserted
at the right position in 'runtimepath'. (Dugan Chen, Norio Takagi)
Solution: Resolve symbolic links when finding the right position in
'runtimepath'. (Hirohito Higashi)
vim/vim@2f9e575
vim-patch:8.0.0325
Problem: Packadd test does not clean up symlink.
Solution: Delete the link. (Hirohito Higashi)
vim/vim@913727e
vim-patch:8.0.0326
Problem: Packadd test uses wrong directory name.
Solution: Use the variable name value. (Hirohito Higashi)
vim/vim@24f8f54
vim-patch:8.0.0437
Problem: The packadd test does not create the symlink correctly and does
not test the right thing.
Solution: Create the directory and symlink correctly.
vim/vim@644df41
vim-patch:8.0.0612
Problem: Package directories are added to 'runtimepath' only after loading
non-package plugins.
Solution: Split off the code to add package directories to 'runtimepath'.
(Ingo Karkat, closes vim/vim#1680)
vim/vim@ce876aa
vim-patch:8.0.0680
Problem: Plugins in start packages are sourced twice. (mseplowitz)
Solution: Use the unmodified runtime path when loading plugins (test by Ingo
Karkat, closes vim/vim#1801)
vim/vim@07ecfa6
Closes #7200
Closes #6869