[RFC] vim-patch:8.0.0142 #7335
[RFC] vim-patch:8.0.0142 #7335
Conversation
Problem: Normal colors are wrong with 'termguicolors'. Solution: Initialize to INVALCOLOR instead of zero. (Ben Jackson, closes vim/vim#1344) vim/vim@0cdb72a
|
Can someone test this? |
|
Steps are laid out in vim/vim#1343, I'd give it a shot if no one else wants to. |
|
I've had a bunch of similar error I fixed in my hilights-related PR ; #7082 and subsequent. It might or not fix this already. |
|
I can't reproduce what's described in vim/vim#1343 (comment), neither in vim (I downloaded 8.0.0141 for the test), nor in nvim. Also the corresponding test does not show a change when run on master vs. run with this PR. You can see the test at KillTheMule@01fcdbd. Not sure how to proceed when I can't reproduce the issue. (e) Ok I could reproduce with vim 8.0.0134, but still not with nvim. |
Yes, nvim behaves differently than vim. It behaves like gvim does in this case. However, IMHO, both nvim and gvim are wrong. They show (bold?) white text on a white background. The background should be black. |
|
It's not black, it's grey right? That's the cursorline, if I'm not mistaken. It's a different grey than in vim though. |
Ah, you're right. nvim and gvim set |
Which is due to differences in the value for |
src/nvim/syntax.c
Outdated
| @@ -6827,6 +6827,9 @@ int hl_combine_attr(int char_attr, int prim_attr) | |||
| new_en = *char_aep; | |||
| } else { | |||
| memset(&new_en, 0, sizeof(new_en)); | |||
| new_en.rgb_fg_color = -1; | |||
There was a problem hiding this comment.
Alternatively, maybe this entire branch can be removed? new_en already has the correct ATTRENTRY_INIT value before the memset().
justinmk
added
needs:response
Problem: Normal colors are wrong with 'termguicolors'. Solution: Initialize to INVALCOLOR instead of zero. (Ben Jackson, closes vim/vim#1344) vim/vim@0cdb72a
….0142 Conflicts: src/nvim/syntax.c
|
Fixed. |
Problem: Normal colors are wrong with 'termguicolors'.
Solution: Initialize to INVALCOLOR instead of zero. (Ben Jackson, closes
vim/vim#1344)
vim/vim@0cdb72a