[RFC] ui: forward relevant options to ui #7520

bfredl · 2017-11-09T12:28:02Z

Some options should have their values forwarded to UIs, both external and TUI. Currently, this only enabled for termguicolors (allowing its value to be changed at runtime), and showtabline (#7516) but I will go through them and add more options that make sense. This would also allow us to restore gui-specific options such as guifont (#4282, #6783). I also plan to use this to reasonably restore input method support (in a later PR).

bfredl · 2017-12-01T19:10:49Z

Mostly done, except possibly a test for improved termguicolors should be added. Marking RFC.

NB: input method options are deliberately excluded, as they will be treated in separate PR.

justinmk · 2017-12-11T20:20:32Z

src/nvim/ui.c

@@ -339,6 +339,7 @@ void ui_attach_impl(UI *ui)
  }

  uis[ui_count++] = ui;
+  refresh_all_ui_options();


ui_refresh_options

justinmk · 2017-12-11T20:49:04Z

runtime/doc/ui.txt

+	`guifontset`
+	`guifontwide`
+	`showtabline`
+	`termguicolors`


use single-quotes for help tags:

'arabicshape' '...'

justinmk · 2017-12-11T20:57:34Z

src/nvim/tui/tui.c

@@ -1136,6 +1137,14 @@ static void tui_set_icon(UI *ui, String icon)
 {
 }

+static void tui_option_set(UI *ui, String name, Object value)
+{
+  if (!strcmp(name.data, "termguicolors")) {


reminder that strequal() exists :P

justinmk · 2017-12-11T20:58:33Z

src/nvim/ui_bridge.c

@@ -144,6 +145,29 @@ static void ui_bridge_highlight_set_event(void **argv)
  xfree(argv[1]);
 }

+static void ui_bridge_option_set(UI *ui, String name, Object value)
+{
+  // Assumes bridge is only used by TUI


VimR uses the bridge.

Maybe wrap this in #ifdef FEAT_TUI ? Not sure if it matters. @qvacua

Sure they are not just calling it "bridge" in analogy? I can't decode the swift/.m-mixture at this hour, but the NvimView folder is full of "msgpack" mentions.

Also, the bridge is already special cased for TUI in other ways; it cannot handle external widgets. This comment mostly adds documentation...

@justinmk @bfredl VimR actually uses the bridge. I only recently started to use the MsgPack API for some non-UI related tasks like getting the list of buffers. Probably VimR should also use the UI MsgPack API, but since I do not plan to implement externalization of widgets anytime soon, it has very low priority... I'll try to use/implement option_set and come back here if I run into problems. 🙂

@qvacua I would say feel free to continue using the bridge. It's an option that we want to support. It should be very easy to support externalized widgets for bridge UIs, also, if it doesn't already ...

also make termguicolors mutable after startup

ref neovim#7520

FEATURES: 3cc7ebf #7234 built-in VimL expression parser 6a7c904 #4419 implement <Cmd> key to invoke command in any mode b836328 #7679 'startup: treat stdin as text instead of commands' 58b210e :digraphs : highlight with hl-SpecialKey #2690 7a13611 #8276 'startup: Let `-s -` read from stdin' 1e71978 events: VimSuspend, VimResume #8280 1e7d5e8 #6272 'stdpath()' f96d99a #8247 server: introduce --listen e8c39f7 #8226 insert-mode: interpret unmapped META as ESC 98e7112 msg: do not scroll entire screen (#8088) f72630b #8055 let negative 'writedelay' show all redraws 5d2dd2e win: has("wsl") on Windows Subsystem for Linux #7330 a4f6cec cmdline: CmdlineEnter and CmdlineLeave autocommands (#7422) 207b7ca #6844 channels: support buffered output and bytes sockets/stdio API: f85cbea #7917 API: buffer updates 418abfc #6743 API: list information about all channels/jobs. 36b2e3f #8375 API: nvim_get_commands 273d2cd #8329 API: Make nvim_set_option() update `:verbose set …` 8d40b36 #8371 API: more reliable/descriptive VimL errors ebb1acb #8353 API: nvim_call_dict_function 9f994bb #8004 API: nvim_list_uis 3405704 #7520 API/UI: forward option updates to UIs 911b1e4 #7821 API: improve nvim_command_output WINDOWS OS: 9cefd83 #8084, #8516 build/win: support MSVC ee4e1fd win: Fix reading content from stdin (#8267) TUI: ffb8904 #8309 TUI: add support for mouse release events in urxvt 8d5a46e #8081 TUI: implement "standout" attribute 6071637 TUI: support TERM=konsole-256color 67848c0 #7653 TUI: report TUI info with -V3 ('verbose' >= 3) 3d0ee17 TUI/rxvt: enable focus-reporting d109f56 #7640 TUI: 'term' option: reflect effective terminal behavior FIXES: ed6a113 #8273 'job-control: avoid kill-timer race' 4e02f1a #8107 'jobs: separate process-group' 451c48a terminal: flush vterm output buffer on pty output #8486 5d6732f :checkhealth fixes #8335 53f11dc #8218 'Fix errors reported by PVS' d05712f inccommand: pause :terminal redraws (#8307) 51af911 inccommand: do not execute trailing commands #8256 84359a4 terminal: resize to the max dimensions (#8249) d49c1dd #8228 Make vim_fgets() return the same values as in Vim 60e96a4 screen: winhl=Normal:Background should not override syntax (#8093) 0c59ac1 #5908 'shada: Also save numbered marks' ba87a2c cscope: ignore EINTR while reading the prompt (#8079) b1412dc #7971 ':terminal Enter/Leave should not increment jumplist' 3a5721e TUI: libtermkey: force CSI driver for mouse input #7948 6ff13d7 #7720 TUI: faster startup 1c6e956 #7862 TUI: fix resize-related segfaults a58c909 #7676 TUI: always hide cursor when flushing, never flush buffers during unibilium output 303e1df #7624 TUI: disable BCE almost always 249bdb0 #7761 mark: Make sure that jumplist item will not have zero lnum 6f41ce0 #7704 macOS: Set $LANG based on the system locale a043899 #7633 'Retry fgets on EINTR' CHANGES: ad60927 #8304 default to 'nofsync' f3f1970 #8035 defaults: 'fillchars' a6052c7 #7984 defaults: sidescroll=1 b69fa86 #7888 defaults: enable cscopeverbose 7c4bb23 defaults: do :filetype stuff unless explicitly "off" 2aa308c #5658 'Apply :lmap in macros' 8ce6393 terminal: Leave 'relativenumber' alone (#8360) e46534b #4486 refactor: Remove maxmem, maxmemtot options 131aad9 win: defaults: 'shellcmdflag', 'shellxquote' #7343 c57d315 #8031 jobwait(): return -2 on interrupt also with timeout 6452831 clipboard: macOS: fallback to tmux if pbcopy is broken #7940 300d365 #7919 Make 'langnoremap' apply directly after a map ada1956 #7880 'lua/executor: Remove lightuserdata' INTERNAL: de0a954 #7806 internal statistics for list impl dee78a4 #7708 rewrite internal list impl

bfredl changed the title ~~[WIP] ui: implement ui options concept~~ [WIP] ui: forward relevant options to ui Nov 9, 2017

marvim added the WIP label Nov 9, 2017

bfredl force-pushed the ui_options branch 6 times, most recently from 6280c99 to 3b5c42b Compare December 1, 2017 18:22

bfredl changed the title ~~[WIP] ui: forward relevant options to ui~~ [RFC] ui: forward relevant options to ui Dec 1, 2017

marvim added RFC and removed WIP labels Dec 1, 2017

bfredl force-pushed the ui_options branch 5 times, most recently from 5bd8450 to 698cac1 Compare December 2, 2017 16:26

bfredl force-pushed the ui_options branch 6 times, most recently from df157f1 to e40d232 Compare December 11, 2017 18:25

justinmk reviewed Dec 11, 2017

View reviewed changes

justinmk approved these changes Dec 11, 2017

View reviewed changes

justinmk reviewed Dec 11, 2017

View reviewed changes

ui: forward relevant option updates to UIs

b593527

also make termguicolors mutable after startup

bfredl force-pushed the ui_options branch from e40d232 to b593527 Compare December 11, 2017 21:36

bfredl merged commit 3405704 into neovim:master Dec 12, 2017

jszakmeister removed the RFC label Dec 12, 2017

justinmk added this to the 0.2.3 milestone Dec 12, 2017

qvacua added a commit to qvacua/vimr that referenced this pull request Dec 13, 2017

Adapt to neovim/neovim#7520

0eab4d5

This was referenced Jan 21, 2018

Option not supported: guifont [Windows] #4282

Closed

guifont and guioptions should be removed from docs #6783

Closed

justinmk added a commit to justinmk/neovim that referenced this pull request Jan 21, 2018

ui: forward 'linespace' option

c46a0d4

ref neovim#7520

justinmk mentioned this pull request Jan 21, 2018

ui: forward 'linespace' option #7883

Merged

justinmk added a commit to justinmk/neovim that referenced this pull request Jan 21, 2018

ui: forward 'linespace' option neovim#7883

caf9d4e

ref neovim#7520

justinmk added a commit to justinmk/neovim that referenced this pull request Jan 21, 2018

ui: forward 'linespace' option neovim#7883

eb4aab7

ref neovim#7520

jdrouhard mentioned this pull request Jan 29, 2018

TUI: Switching termguicolors at runtime in tmux breaks colors until resized #7929

Closed

bfredl mentioned this pull request Mar 16, 2018

UI/API: ext_tabline: 'showtabline' #7516

Closed

qvacua mentioned this pull request Mar 17, 2018

Setting linespace and font from init.vim qvacua/vimr#506

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RFC] ui: forward relevant options to ui #7520

[RFC] ui: forward relevant options to ui #7520

bfredl commented Nov 9, 2017

bfredl commented Dec 1, 2017

justinmk Dec 11, 2017

justinmk Dec 11, 2017

justinmk Dec 11, 2017

justinmk Dec 11, 2017 •

edited

Loading

bfredl Dec 11, 2017

qvacua Dec 13, 2017

justinmk Dec 13, 2017

[RFC] ui: forward relevant options to ui #7520

[RFC] ui: forward relevant options to ui #7520

Conversation

bfredl commented Nov 9, 2017

bfredl commented Dec 1, 2017

justinmk Dec 11, 2017

Choose a reason for hiding this comment

justinmk Dec 11, 2017

Choose a reason for hiding this comment

justinmk Dec 11, 2017

Choose a reason for hiding this comment

justinmk Dec 11, 2017 • edited Loading

Choose a reason for hiding this comment

bfredl Dec 11, 2017

Choose a reason for hiding this comment

qvacua Dec 13, 2017

Choose a reason for hiding this comment

justinmk Dec 13, 2017

Choose a reason for hiding this comment

justinmk Dec 11, 2017 •

edited

Loading