build: enforce type checks, fix type errors #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
force-pushed
the
fixtypeerr
branch
3 times, most recently
from
27b37ce
to
8092b95
Compare
Also ignore node_modules/ at all levels.
ref #352 Before: src/api/Buffer.test.ts:102:9 - error TS2304: Cannot find name 'expect'. ... src/api/Buffer.test.ts:106:5 - error TS2593: Cannot find name 'it'. Do you need to install type definitions for a test runner? Try `npm i --save-dev @types/jest` or `npm i --save-dev @types/mocha` and then add 'jest' or 'mocha' to the types field in your tsconfig. ... Found 616 errors in 8 files. After: Found 138 errors in 6 files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
"strict": truein tsconfigTODO
tsconfig ignores the test files...?
node-client/packages/neovim/tsconfig.json
Line 7 in d3bc8d3
#352