Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: enforce type checks, fix type errors #338

Merged
merged 3 commits into from
Apr 17, 2024
Merged

build: enforce type checks, fix type errors #338

merged 3 commits into from
Apr 17, 2024

Commits on Apr 17, 2024

  1. fix type errors 

    Also ignore node_modules/ at all levels.
    @justinmk
    justinmk committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    4c85e12 View commit details
    Browse the repository at this point in the history

  2. fix: "JSDoc types may be moved to TypeScript types"

    @justinmk
    justinmk committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    93c478d View commit details
    Browse the repository at this point in the history

  3. fix(build): "Cannot find name 'expect'" 

    ref #352

Before:

    src/api/Buffer.test.ts:102:9 - error TS2304: Cannot find name 'expect'.
    ...
    src/api/Buffer.test.ts:106:5 - error TS2593: Cannot find name 'it'.
    Do you need to install type definitions for a test runner? Try `npm
    i --save-dev @types/jest` or `npm i --save-dev @types/mocha` and
    then add 'jest' or 'mocha' to the types field in your tsconfig.
    ...
    Found 616 errors in 8 files.

After:

    Found 138 errors in 6 files.
    @justinmk
    justinmk committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    ff491d8 View commit details
    Browse the repository at this point in the history