Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Ruby LSP team calls the LSP server
ruby-lsp
, while nvim-lspconfig calls itruby_ls
. The ruby-lsp team have suggested that this be renamed toruby_lsp
so the naming is consistent everywhere (comment). cc @vinistockAs part of this, I've also added a deprecation, so that people using
ruby_ls
in their config will be notified, but can continue usingruby-lsp
.Testing
Tested with my neovim config which uses mason-lspconfig.nvim to set up ruby_ls.
I've tested that ruby-lsp continues working even after the rename, but with this deprecation message on load:
Next steps