Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rename ruby_ls to ruby_lsp #3105

Merged
merged 1 commit into from
Apr 14, 2024
Merged

Conversation

nithinbekal
Copy link
Contributor

@nithinbekal nithinbekal commented Apr 12, 2024

Description

The Ruby LSP team calls the LSP server ruby-lsp, while nvim-lspconfig calls it ruby_ls. The ruby-lsp team have suggested that this be renamed to ruby_lsp so the naming is consistent everywhere (comment). cc @vinistock

As part of this, I've also added a deprecation, so that people using ruby_ls in their config will be notified, but can continue using ruby-lsp.

Testing

Tested with my neovim config which uses mason-lspconfig.nvim to set up ruby_ls.

I've tested that ruby-lsp continues working even after the rename, but with this deprecation message on load:

ruby_ls is deprecated, use ruby_lsp instead.
This feature will be removed in lspconfig version 0.2.0

Next steps

Copy link
Contributor

Do not change server_configurations.md or server_configurations.txt directly as these are automatically generated. Edit the lua source file instead. See https://github.com/neovim/nvim-lspconfig/blob/master/CONTRIBUTING.md#generating-docs

Copy link
Contributor

Do not change server_configurations.md or server_configurations.txt directly as these are automatically generated. Edit the lua source file instead. See https://github.com/neovim/nvim-lspconfig/blob/master/CONTRIBUTING.md#generating-docs

@glepnir glepnir merged commit 40f9286 into neovim:master Apr 14, 2024
9 checks passed
@kevintraver
Copy link

Is there a way to hide or suppress the warning?

Warn: ruby_ls is deprecated, use ruby_lsp instead.
This feature will be removed in lspconfig version 0.2.0

@nithinbekal
Copy link
Contributor Author

@kevintraver How have you configured Ruby LSP? If you're using mason-lspconfig, you might need to wait till williamboman/mason-lspconfig.nvim#395 gets merged.

@kevintraver
Copy link

Yes, I am using mason-lspconfig, which is why I was just curious if there's a way to hide the notice until it's resolved. If not, it's no problem at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants