ci: fix failing readthedocs build by adding sphinx_rtd_theme dependency #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
reviewed
Dec 11, 2023
| - method: pip | ||
| path: . | ||
| extra_requirements: | ||
| - sphinx_rtd_theme |
There was a problem hiding this comment.
should it be sphinx-rtd-theme ?
There was a problem hiding this comment.
Actually this translated to pip install .[sphinx_rtd_theme] (sorry the docs were not clear enough...). So I think the solution is to change this with docs and add sphinx-rtd-theme into extra_requires['docs'].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might fix the failing readthedocs CI #552 issue (can't fully test until merged).