Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New syscalls itoa atoi #304

Merged
merged 6 commits into from
Jan 12, 2021
Merged

New syscalls itoa atoi #304

merged 6 commits into from
Jan 12, 2021

Conversation

csmuller
Copy link
Member

Closes #287.

@csmuller csmuller added this to the neow3j 3.6.0 milestone Dec 10, 2020
@csmuller csmuller self-assigned this Dec 10, 2020
@csmuller csmuller changed the base branch from master-3.x to develop-3.x December 10, 2020 10:27
@gsmachado gsmachado assigned gsmachado and unassigned gsmachado and csmuller Jan 11, 2021
@gsmachado
Merge branch 'develop-3.x' into feature/syscalls-itoa-atoi
4189184 
* develop-3.x: (120 commits)
  Fix integration test for NeoToken.vote().
  Fix getCanidates unit test.
  Update SDK's NeoToken.
  Write devpack NeoToken tests.
  Update NeoToken in devpack.
  Change signger scope for tests to global by default.
  Apply suggestions from code review
  Remove wrong tests from NeoTokenTest. Add GasToken test.
  Add integration tests for devpack's Nep17Token and NeoToken.
  Add transfer method to Nep17Token contract interface.
  Correct compiler's handling of contract interface classes.
  Correct and extend integration tests.
  Fix unit tests.
  Imporve JavaDoc.
  Fix JavaDoc issues.
  Fix compiler-related integration tests.
  Correct compiler-related integration tests.
  Update native contract hashes.
  Fix bug in fetching of network fee.
  Fix contract deployment for compiler integration tests.
  ...

# Conflicts:
#	utils/src/main/java/io/neow3j/constants/InteropServiceCode.java
@gsmachado gsmachado marked this pull request as ready for review January 12, 2021 14:15
@csmuller csmuller assigned csmuller and unassigned gsmachado Jan 12, 2021
@csmuller csmuller assigned csmuller and unassigned csmuller Jan 12, 2021
@gsmachado gsmachado self-requested a review January 12, 2021 17:18
gsmachado
gsmachado approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@gsmachado gsmachado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 👍

@gsmachado gsmachado merged commit 1c326e0 into develop-3.x Jan 12, 2021
@gsmachado gsmachado deleted the feature/syscalls-itoa-atoi branch January 12, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmachado gsmachado gsmachado approved these changes

Assignees

@csmuller csmuller

Labels
devpack
Projects
None yet
Milestone
neow3j 3.6.0
Development

Successfully merging this pull request may close these issues.

Add support for two new syscalls Itoa and Atoi
2 participants
@csmuller @gsmachado