Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect incompatible DJANGO_SETTINGS_MODULE #338

Merged
merged 1 commit into from Dec 22, 2018

Conversation

yakky
Copy link
Member

@yakky yakky commented Dec 22, 2018

if DJANGO_SETTINGS_MODULE is set in a way which is incompatible with django CMS installer, the install will fail with obscure errors

By checking on start, we can ensure to return a clearer error message to the user

Fix #330

@yakky yakky added this to the 1.1 milestone Dec 22, 2018
@codecov
Copy link

codecov bot commented Dec 22, 2018

Codecov Report

Merging #338 into develop will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #338      +/-   ##
===========================================
+ Coverage     90.7%   90.92%   +0.22%     
===========================================
  Files            7        7              
  Lines          656      661       +5     
  Branches       139      140       +1     
===========================================
+ Hits           595      601       +6     
  Misses          28       28              
+ Partials        33       32       -1
Impacted Files Coverage Δ
djangocms_installer/config/__init__.py 91.01% <100%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85238dd...cdaf72f. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 95.783% when pulling cdaf72f on feature/detect_settings_module_env into 85238dd on develop.

@yakky yakky merged commit 212a27e into develop Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants