Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tooling and drop Python 2 / Django < 2.2 #62

Merged
merged 5 commits into from
Nov 12, 2020

Conversation

protoroto
Copy link
Member

Update tooling:

  • github actions
  • pre-commit
  • towncrier / bump2version

Drop python 2 / Django < 2.2

@protoroto protoroto force-pushed the feature/us-10208-update-tooling branch 3 times, most recently from 44d11e2 to 4a39823 Compare November 12, 2020 14:57
@protoroto protoroto force-pushed the feature/us-10208-update-tooling branch from 4a39823 to 4a756e9 Compare November 12, 2020 15:02
@protoroto protoroto requested a review from yakky November 12, 2020 15:28
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #62 (d266d14) into develop (3084c1e) will increase coverage by 1.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop       #62      +/-   ##
============================================
+ Coverage    98.76%   100.00%   +1.23%     
============================================
  Files            8         8              
  Lines          162       148      -14     
  Branches        16        16              
============================================
- Hits           160       148      -12     
+ Misses           2         0       -2     
Flag Coverage Δ
unittests 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
djangocms_page_sitemap/admin.py 100.00% <ø> (ø)
djangocms_page_sitemap/sitemap_urls.py 100.00% <ø> (ø)
djangocms_page_sitemap/cms_toolbars.py 100.00% <100.00%> (ø)
djangocms_page_sitemap/models.py 100.00% <100.00%> (ø)
djangocms_page_sitemap/settings.py 100.00% <100.00%> (ø)
djangocms_page_sitemap/sitemap.py 100.00% <100.00%> (ø)
...jangocms_page_sitemap/templatetags/robots_index.py 100.00% <100.00%> (ø)
djangocms_page_sitemap/utils.py 100.00% <100.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c16fae8...d266d14. Read the comment docs.

@protoroto protoroto force-pushed the feature/us-10208-update-tooling branch from a872f45 to 6320e1e Compare November 12, 2020 15:38
pyproject.toml Outdated Show resolved Hide resolved
LICENSE Outdated Show resolved Hide resolved
Copy link
Member

@yakky yakky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of page-meta to replace with page-sitemap

@yakky yakky merged commit 05c93d5 into develop Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants