Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to parse repo name when GitLab repo name contains a - character #42

Closed
nasifimtiazohi opened this issue Nov 18, 2021 · 1 comment

Comments

@nasifimtiazohi
Copy link

Description

Fails to parse repo name when GitLab repo name contains a - character.

Steps to reproduce

test case: s = 'https://gitlab.com/sheepkill15/cypress-helper/-/blob/main/.vscodeignore'

Versions

Python >= 3.7
gitulrparse = 0.10.0

Expected behaviour

parse(s).repo == 'cypress-helper'

Actual behaviour

parse(s).repo == '-'

boozec added a commit to boozec/giturlparse that referenced this issue Sep 2, 2023
Gitlab URLs has the format with "/-/blob/". This commit fixs the parser
editing the FORMAT string with the "/-/" before the ('blob'|'tree').

Resolves nephila#42
@protoroto
Copy link
Member

@nasifimtiazohi We've released 0.12.0 that should fix this, thanks to @boozec ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants