Fix Gitlab parsing for repo with -
#76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gitlab URLs has the format with "/-/blob/". This commit fixs the parser
editing the FORMAT string with the "/-/" before the ('blob'|'tree').
Resolves nephila#42
For retrocompatibility
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #76 +/- ##
=========================================
Coverage ? 94.22%
=========================================
Files ? 12
Lines ? 225
Branches ? 49
=========================================
Hits ? 212
Misses ? 10
Partials ? 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@boozec Sorry to bother, but after merging |
|
Hi @protoroto it was caused by a typo with a |
Thank you very much! I really hope we'll be able to merge this and release a new version as soon as possible! |
yakky
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all 👋 unfortunately the branch rename closed the old PR at #74
Description
Gitlab URLs has the format with "/-/blob/". This PR fixs the parser editing the FORMAT string with the "/-/" before the ('blob'|'tree').
eg: The string "https://gitlab.com/gitlab-org/gitlab/blob/master/README.md" is valid as "https://gitlab.com/gitlab-org/gitlab/-/blob/master/README.md".
References
Fixs #42
Checklist
inv lint