Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netwcfg API #46

Merged
merged 4 commits into from
Jun 15, 2023
Merged

Netwcfg API #46

merged 4 commits into from
Jun 15, 2023

Conversation

henderiw
Copy link
Contributor

provides config CRD to configure network devices
provide additional configuration to the network API. Parameters that are not necessarily exposed to the intent creator. These are params for the engineers

@johnbelamaric
Copy link
Member

There seem to be some other commits mixed in. What's the new part, is it possible to split out that?

The networks CRD for example we already have, also those "cond" changes look familiar, I think they are already merged.

@henderiw
Copy link
Contributor Author

this is new.

  1. the config CRD is the CRD that is the one providing the config of the network device
  2. the networkConfig is a CRD that is for the network people deploying the networks. They have default for various scenario's. Like pick prefix length x is it is an internal link, etc.

@johnbelamaric
Copy link
Member

/approve
/lgtm

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Jun 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jun 15, 2023
@nephio-prow nephio-prow bot merged commit ceb0d10 into nephio-project:main Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants