Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specializer updates #269

Merged
merged 10 commits into from
Jun 9, 2023
Merged

Conversation

henderiw
Copy link
Contributor

@henderiw henderiw commented Jun 8, 2023

Updates in the specialised

  • dealing with ipv4 and ipv6
  • fixes bugs

@nephio-prow nephio-prow bot requested review from s3wong and tliron June 8, 2023 12:26
@henderiw henderiw requested review from ganchandrasekaran, kispaljr, aakashchan and johnbelamaric and removed request for s3wong and tliron June 9, 2023 03:41
@henderiw
Copy link
Contributor Author

henderiw commented Jun 9, 2023

/hold

@henderiw
Copy link
Contributor Author

henderiw commented Jun 9, 2023

/hold cancel

krm-functions/dnn-fn/fn/function.go Outdated Show resolved Hide resolved
krm-functions/dnn-fn/fn/function.go Show resolved Hide resolved
krm-functions/dnn-fn/fn/function.go Show resolved Hide resolved
krm-functions/interface-fn/fn/function.go Outdated Show resolved Hide resolved
Copy link
Member

@johnbelamaric johnbelamaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot here...I gave it a once over but I am relying a lot on the tests.

/approve
/lgtm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we using this operator? I thought this is all in the nephio-operator now? If we are not using it, we should probably remove it entirely

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Jun 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jun 9, 2023
@nephio-prow nephio-prow bot merged commit 85aa390 into nephio-project:main Jun 9, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants