Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement parallelism in KPT Ansible tasks #161

Merged
merged 3 commits into from
Jul 14, 2023

Conversation

electrocucaracha
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
Bootstrap and Install Ansible roles applies kpt packages sequentially, resulting in long provisioning process. This change allows applying some kpt packages concurrently and delays the deployment waiting process after all the packages have been applied. This change shows a reduction in 20%

Task Before After
kpt 444.90s 258.70s
bootstrap 95.69s 115.89s
install 1.03s 21.51s

Which issue(s) this PR fixes:

NA

Special notes for your reviewer:

  • Molecule version required to downgrade for accepting CPU/Memory definition.
  • Fixed some linting issues not reported in the current version.
  • Kpt packages seems to have some dependencies which results in partial concurrent implementation.

Does this PR introduce a user-facing change?:

Enable concurrency on the execution of kpt packages.

Signed-off-by: Victor Morales <v.morales@samsung.com>
Signed-off-by: Victor Morales <v.morales@samsung.com>
Signed-off-by: Victor Morales <v.morales@samsung.com>
@nephio-prow
Copy link
Contributor

nephio-prow bot commented Jul 14, 2023

@electrocucaracha: The label(s) kind/feature cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
Bootstrap and Install Ansible roles applies kpt packages sequentially, resulting in long provisioning process. This change allows applying some kpt packages concurrently and delays the deployment waiting process after all the packages have been applied. This change shows a reduction in 20%

Task Before After
kpt 444.90s 258.70s
bootstrap 95.69s 115.89s
install 1.03s 21.51s

Which issue(s) this PR fixes:

NA

Special notes for your reviewer:

  • Molecule version required to downgrade for accepting CPU/Memory definition.
  • Fixed some linting issues not reported in the current version.
  • Kpt packages seems to have some dependencies which results in partial concurrent implementation.

Does this PR introduce a user-facing change?:

Enable concurrency on the execution of kpt packages.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@radoslawc
Copy link
Collaborator

/retest

@johnbelamaric
Copy link
Member

/lgtm
/approve

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Jul 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: electrocucaracha, johnbelamaric

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Jul 14, 2023
@nephio-prow nephio-prow bot merged commit 5684428 into nephio-project:main Jul 14, 2023
@electrocucaracha electrocucaracha deleted the implement_async branch July 14, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants