Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 001.sh assertions #203

Merged

Conversation

electrocucaracha
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
This change includes the addition of assertions to validate the state of resources and content of logs for the 001.sh test script. This will facilitate the detection of issues when an error happens.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@radoslawc
Copy link
Collaborator

/approve

@nephio-prow
Copy link
Contributor

nephio-prow bot commented Oct 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: radoslawc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@electrocucaracha
Copy link
Member Author

/retest

@radoslawc
Copy link
Collaborator

/test e2e-ubuntu-focal

@radoslawc
Copy link
Collaborator

/test e2e-fedora-34

@electrocucaracha electrocucaracha force-pushed the add_assertions_001 branch 2 times, most recently from 88a3fb6 to de3d97c Compare October 31, 2023 23:13
@electrocucaracha
Copy link
Member Author

@vjayaramrh @johnbelamaric @radoslawc this PR is ready to be reviewed, the e2e errors are not caused by these changes. My plans are to harden the testing code, adding assertions and more waiting functions.

Signed-off-by: Victor Morales <v.morales@samsung.com>
@radoslawc
Copy link
Collaborator

/lgtm

@electrocucaracha
Copy link
Member Author

/override e2e-ubuntu-focal

Copy link
Contributor

nephio-prow bot commented Nov 13, 2023

@electrocucaracha: Overrode contexts on behalf of electrocucaracha: e2e-ubuntu-focal

In response to this:

/override e2e-ubuntu-focal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nephio-prow nephio-prow bot merged commit e50bda7 into nephio-project:main Nov 13, 2023
3 of 4 checks passed
@electrocucaracha electrocucaracha deleted the add_assertions_001 branch November 13, 2023 17:09
dkosteck pushed a commit to vjayaramrh/test-infra that referenced this pull request Aug 15, 2024
Signed-off-by: Victor Morales <v.morales@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants