-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable 001.sh assertions #203
Enable 001.sh assertions #203
Conversation
e3cff2f
to
c5fcf40
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: radoslawc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c5fcf40
to
8e20e93
Compare
/retest |
/test e2e-ubuntu-focal |
/test e2e-fedora-34 |
88a3fb6
to
de3d97c
Compare
@vjayaramrh @johnbelamaric @radoslawc this PR is ready to be reviewed, the e2e errors are not caused by these changes. My plans are to harden the testing code, adding assertions and more waiting functions. |
de3d97c
to
0684743
Compare
Signed-off-by: Victor Morales <v.morales@samsung.com>
0684743
to
525e80f
Compare
/lgtm |
/override e2e-ubuntu-focal |
@electrocucaracha: Overrode contexts on behalf of electrocucaracha: e2e-ubuntu-focal In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Victor Morales <v.morales@samsung.com>
What type of PR is this?
/kind feature
What this PR does / why we need it:
This change includes the addition of assertions to validate the state of resources and content of logs for the 001.sh test script. This will facilitate the detection of issues when an error happens.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: