Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fail fast CI feature to reduce the End-to-End testing consumption #230

Merged
merged 10 commits into from
Jan 25, 2024

Conversation

electrocucaracha
Copy link
Member

@electrocucaracha electrocucaracha commented Jan 11, 2024

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
The current test-infra End-to-End testing behavior continues executing tests until the end. In some cases, this could extend the testing time and block or misuse the CI resources. This change enables a feature to stop the End-to-End execution if a failure is previously raised.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@electrocucaracha
Copy link
Member Author

/test e2e-oai-ubuntu-jammy

@radoslawc
Copy link
Collaborator

/approve

@nephio-prow nephio-prow bot added the approved label Jan 12, 2024
@arora-sagar
Copy link
Contributor

@electrocucaracha To test this don't we need new porch version. With old version it will always fail and will have timeout. As porch is not able to find the sub-directories.

@electrocucaracha electrocucaracha changed the title Use main branch and fail_fast in on demand CI tasks Enable fail fast CI feature to reduce the End-to-End testing consumption Jan 17, 2024
@electrocucaracha
Copy link
Member Author

/retest

@lapentad
Copy link
Contributor

@electrocucaracha nice catch on the free5gc reconciler!
005.sh passed and 006.sh failed I wonder if it's a timing issue

@electrocucaracha
Copy link
Member Author

@electrocucaracha nice catch on the free5gc reconciler! 005.sh passed and 006.sh failed I wonder if it's a timing issue

I'm experimenting with different VM flavors to see if there is an improvement on provisioning, but in the meantime we need to merge the two PRs in the Catalog repo

@radoslawc
Copy link
Collaborator

/lgtm

.prow.yaml Outdated Show resolved Hide resolved
@electrocucaracha
Copy link
Member Author

/retest

2 similar comments
@electrocucaracha
Copy link
Member Author

/retest

@electrocucaracha
Copy link
Member Author

/retest

@electrocucaracha
Copy link
Member Author

/test e2e-oai-ubuntu-jammy

2 similar comments
@electrocucaracha
Copy link
Member Author

/test e2e-oai-ubuntu-jammy

@electrocucaracha
Copy link
Member Author

/test e2e-oai-ubuntu-jammy

Signed-off-by: Victor Morales <v.morales@samsung.com>
Signed-off-by: Victor Morales <v.morales@samsung.com>
Signed-off-by: Victor Morales <v.morales@samsung.com>
Signed-off-by: Victor Morales <v.morales@samsung.com>
Signed-off-by: Victor Morales <v.morales@samsung.com>
Signed-off-by: Victor Morales <v.morales@samsung.com>
Signed-off-by: Victor Morales <v.morales@samsung.com>
Signed-off-by: Victor Morales <v.morales@samsung.com>
Signed-off-by: Victor Morales <v.morales@samsung.com>
Signed-off-by: Victor Morales <v.morales@samsung.com>
@efiacor
Copy link
Contributor

efiacor commented Jan 25, 2024

/approve

Copy link
Contributor

nephio-prow bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, radoslawc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@efiacor
Copy link
Contributor

efiacor commented Jan 25, 2024

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jan 25, 2024
@nephio-prow nephio-prow bot merged commit 7a82a1f into nephio-project:main Jan 25, 2024
8 checks passed
Copy link
Contributor

nephio-prow bot commented Jan 25, 2024

@electrocucaracha: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/config/config.yaml

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
The current test-infra End-to-End testing behavior continues executing tests until the end. In some cases, this could extend the testing time and block or misuse the CI resources. This change enables a feature to stop the End-to-End execution if a failure is previously raised.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@electrocucaracha electrocucaracha deleted the improve_periodic branch January 25, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants