Updating the location of files

[arora-sagar]

/kind cleanup

What this PR does / why we need it:

• Moving yaml definitions from script to yaml files
• Adding connectivity testing script

Special notes for your reviewer:
Updated the scripts to keep the yaml files out of the script.

Does this PR introduce a user-facing change?:
NO

[efiacor]

Minor comment.
I understand the logic for naming the .sh files incrementaly for test execution purposes but to me it's not very intuitive as to what each one is doing without opening the file.
For the yaml files I think it would be good to keep the suffix of what it contains rather than 003.yaml etc.

[arora-sagar]

Minor comment. I understand the logic for naming the .sh files incrementaly for test execution purposes but to me it's not very intuitive as to what each one is doing without opening the file. For the yaml files I think it would be good to keep the suffix of what it contains rather than 003.yaml etc.

I agree I just used the approach of R1. For yaml files I can change the name

002.yaml --> 002-database.yaml and 002-operators.yaml
003.yaml --> 003-core-network.yaml
004.yaml --> 004-ran-network.yaml

For test scripts, I can change to

001.sh --> 001-infra.sh
002.sh --> 002-dependency.sh
003.sh --> 003-core-network.sh
004.sh --> 004-ran-network.sh
005.sh --> 005-ue.sh
006.sh --> 006-end-to-end-call.sh

What do you think @efiacor ? Though I need @electrocucaracha approval too

[liamfallon]

Minor comment. I understand the logic for naming the .sh files incrementaly for test execution purposes but to me it's not very intuitive as to what each one is doing without opening the file. For the yaml files I think it would be good to keep the suffix of what it contains rather than 003.yaml etc.

I agree I just used the approach of R1. For yaml files I can change the name

002.yaml --> 002-database.yaml and 002-operators.yaml
003.yaml --> 003-core-network.yaml
004.yaml --> 004-ran-network.yaml

For test scripts, I can change to

001.sh --> 001-infra.sh
002.sh --> 002-dependency.sh
003.sh --> 003-core-network.sh
004.sh --> 004-ran-network.sh
005.sh --> 005-ue.sh
006.sh --> 006-end-to-end-call.sh

What do you think @efiacor ? Though I need @electrocucaracha approval too

Minor comment. I understand the logic for naming the .sh files incrementaly for test execution purposes but to me it's not very intuitive as to what each one is doing without opening the file. For the yaml files I think it would be good to keep the suffix of what it contains rather than 003.yaml etc.

I agree I just used the approach of R1. For yaml files I can change the name

002.yaml --> 002-database.yaml and 002-operators.yaml
003.yaml --> 003-core-network.yaml
004.yaml --> 004-ran-network.yaml

For test scripts, I can change to

001.sh --> 001-infra.sh
002.sh --> 002-dependency.sh
003.sh --> 003-core-network.sh
004.sh --> 004-ran-network.sh
005.sh --> 005-ue.sh
006.sh --> 006-end-to-end-call.sh

What do you think @efiacor ? Though I need @electrocucaracha approval too

I agree with this proposal Sagar. I think this is better.

[electrocucaracha]

I like the idea to provide some hint thru the file names, let's rename those files to something that make more sense

[efiacor]

Minor comment. I understand the logic for naming the .sh files incrementaly for test execution purposes but to me it's not very intuitive as to what each one is doing without opening the file. For the yaml files I think it would be good to keep the suffix of what it contains rather than 003.yaml etc.

I agree I just used the approach of R1. For yaml files I can change the name

002.yaml --> 002-database.yaml and 002-operators.yaml
003.yaml --> 003-core-network.yaml
004.yaml --> 004-ran-network.yaml

For test scripts, I can change to

001.sh --> 001-infra.sh
002.sh --> 002-dependency.sh
003.sh --> 003-core-network.sh
004.sh --> 004-ran-network.sh
005.sh --> 005-ue.sh
006.sh --> 006-end-to-end-call.sh

What do you think @efiacor ? Though I need @electrocucaracha approval too

Perfect. Thank you sir.

[electrocucaracha]

@arora-sagar I have seen this issue frequently in Ubuntu Jammy images, where the official Ubuntu repository is locked. We can create in R3+ our private repo to mitigate these dependencies.

[arora-sagar]

Do you see this in focal too? Probably we can move to focal for R2. Best Regards,Sagar AroraOn 25 Jan 2024, at 18:01, Victor Morales ***@***.***> wrote: @arora-sagar I have seen this issue frequently in Ubuntu Jammy images, where the official Ubuntu repository is locked. We can create in R3+ our private repo to mitigate these dependencies. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

[electrocucaracha]

Do you see this in focal too? Probably we can move to focal for R2. Best Regards,Sagar Arora

No too often, that's another possibility.

[electrocucaracha]

These changes don't have any related change to free5gc so we can ignore the issues.

/override e2e-free5gc-fedora-34
/override e2e-free5gc-ubuntu-focal

[nephio-prow]

@electrocucaracha: Overrode contexts on behalf of electrocucaracha: e2e-free5gc-fedora-34, e2e-free5gc-ubuntu-focal

In response to this:

These changes don't have any related change to free5gc so we can ignore the issues.

/override e2e-free5gc-fedora-34
/override e2e-free5gc-ubuntu-focal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[electrocucaracha]

Give a second try to OAI End-to-End test execution

/test e2e-oai-ubuntu-jammy

[electrocucaracha]

This seems to be a timeout issue with is already addressed on #230

/override e2e-oai-ubuntu-jammy
/lgtm
/approve

[nephio-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: electrocucaracha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [electrocucaracha]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nephio-prow]

@electrocucaracha: Overrode contexts on behalf of electrocucaracha: e2e-oai-ubuntu-jammy

In response to this:

This seems to be a timeout issue with is already addressed on #230

/override e2e-oai-ubuntu-jammy
/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.