Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default lgtm label behaviour #40

Merged
merged 1 commit into from
May 18, 2023
Merged

Change default lgtm label behaviour #40

merged 1 commit into from
May 18, 2023

Conversation

electrocucaracha
Copy link
Member

According to the documentation, the lgtm_acts_as_approve is set to true by default, this value results in undesired approvals on code reviews.

@electrocucaracha
Change lgtm behaviour
72f6bda 
According to the documentation, the lgtm_acts_as_approve is set to true by
default, this value results in undesired approvals on code reviews. This change
disables that functionality.

https://github.com/kubernetes/test-infra/blob/master/prow/plugins/plugin-config-documented.yaml

Signed-off-by: Victor Morales <v.morales@samsung.com>
@radoslawc
Copy link
Collaborator

/approve

@nephio-prow
Copy link
Contributor

nephio-prow bot commented May 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: electrocucaracha, radoslawc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label May 18, 2023
@radoslawc
Copy link
Collaborator

/lgtm

@nephio-prow nephio-prow bot added the lgtm label May 18, 2023
@nephio-prow nephio-prow bot merged commit 35ae31e into nephio-project:main May 18, 2023
@nephio-prow
Copy link
Contributor

nephio-prow bot commented May 18, 2023

@electrocucaracha: Updated the plugins configmap in namespace prow at cluster default using the following files:

  • key plugins.yaml using file prow/config/plugins.yaml

In response to this:

According to the documentation, the lgtm_acts_as_approve is set to true by default, this value results in undesired approvals on code reviews.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@electrocucaracha electrocucaracha deleted the fix-lgtm branch May 18, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aravind254 aravind254 Awaiting requested review from aravind254

@radoslawc radoslawc Awaiting requested review from radoslawc

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@gvbalaji gvbalaji Awaiting requested review from gvbalaji

@henderiw henderiw Awaiting requested review from henderiw

Assignees

@radoslawc radoslawc

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@electrocucaracha @radoslawc