Use sysctl Ansible module #60
Conversation
I just noticed that I need to fix the terraform scripts. I'll include the fix here as well |
electrocucaracha
force-pushed
the
use_sysctl
branch
from
0a57cad
to
27bfda0
Compare
|
/lgtm |
|
@vishwanathj: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest I'm not sure why this took more than 2hrs to complete |
electrocucaracha
force-pushed
the
use_sysctl
branch
from
de35982
to
017bfa8
Compare
electrocucaracha
force-pushed
the
use_sysctl
branch
from
017bfa8
to
45ec481
Compare
| @@ -20,6 +20,9 @@ Vagrant.configure('2') do |config| | |||
| config.vm.box_check_update = false | |||
| config.vm.synced_folder './', '/vagrant' | |||
|
|
|||
| config.vm.network 'forwarded_port', guest: 7007, guest_ip: '127.0.0.1', host: 7007 | |||
There was a problem hiding this comment.
nice, so in the vagrant case you do not need the -L in your ssh? We should document that. You will still need to do the kubectl port forwarding, unless we expose the UI on a 172.18.0.0/20 address. Which I think in general would be fine for the sandbox, even though there is no authentication on the UI in sandbox mode. I'll create a separate issue to discuss that.
| @@ -20,6 +20,9 @@ Vagrant.configure('2') do |config| | |||
| config.vm.box_check_update = false | |||
| config.vm.synced_folder './', '/vagrant' | |||
|
|
|||
| config.vm.network 'forwarded_port', guest: 7007, guest_ip: '127.0.0.1', host: 7007 | |||
| config.vm.network 'forwarded_port', guest: 3000, guest_ip: '172.18.0.200', host: 3000 | |||
There was a problem hiding this comment.
In general, might be a good practice to open a separate PR when adding other functionalities.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: electrocucaracha, johnbelamaric, radoslawc, vishwanathj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change implements this change and fixes the Vagrantfile and gitea default user defined in the Bootstrap Ansible role