Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve editorial description #75

Merged
merged 3 commits into from
Jun 9, 2023
Merged

Improve editorial description #75

merged 3 commits into from
Jun 9, 2023

Conversation

debeaueric
Copy link
Contributor

  • Add title2 for steps

  • Add command to create secrets for edge clusters

  • Align style guide with https://kubernetes.io/docs/contribute/style/style-guide/

    • Use simple and direct language
    • Address the reader as "you"
    • Code snippet formatting: Don't include the command prompt
    • Code snippet formatting: Separate commands from output

@debeaueric
Improve editorial description
529ca08 
- Add title2 for steps
- Add command to create secrets for edge clusters

- Align style guide with https://kubernetes.io/docs/contribute/style/style-guide/
  - Use simple and direct language
  - Address the reader as "you"
  - Code snippet formatting: Don't include the command prompt
  - Code snippet formatting: Separate commands from output
@nephio-prow
Copy link
Contributor

nephio-prow bot commented Jun 9, 2023

Hi @debeaueric. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

johnbelamaric
johnbelamaric reviewed Jun 9, 2023
View reviewed changes
Copy link
Member

@johnbelamaric johnbelamaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks. I have to run now but reviewed through step 6 or 7.

e2e/provision/README.md Outdated Show resolved Hide resolved
e2e/provision/README.md Show resolved Hide resolved
e2e/provision/README.md Show resolved Hide resolved
e2e/provision/README.md Outdated Show resolved Hide resolved
e2e/provision/README.md
```

If you wanted to, you could have used the `--save` option to add the
`set-labels` call to the package pipeline. This would mean that function gets
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/that/that that/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do net see where to change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"would mean that function" vs "would mean that that function". It's not critical, I think it reads OK either way.

e2e/provision/README.md Outdated Show resolved Hide resolved
e2e/provision/README.md Outdated Show resolved Hide resolved
@debeaueric
Fix typo gcloud
8757929
@debeaueric
Fix review typos
4570f2e 
Fix different typos after review by John
@johnbelamaric
Copy link
Member

/approve
/lgtm

@nephio-prow nephio-prow bot added the lgtm label Jun 9, 2023
@nephio-prow
Copy link
Contributor

nephio-prow bot commented Jun 9, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: debeaueric, johnbelamaric
Once this PR has been reviewed and has the lgtm label, please assign radoslawc for approval by writing /assign @radoslawc in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@electrocucaracha
Copy link
Member

/lgtm

@johnbelamaric
Copy link
Member

Only @radoslawc and @aravind254 have approval rights in this repo.

@johnbelamaric johnbelamaric merged commit f5ec26b into nephio-project:main Jun 9, 2023
@debeaueric debeaueric deleted the patch-2 branch June 14, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbelamaric johnbelamaric johnbelamaric left review comments

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@radoslawc radoslawc Awaiting requested review from radoslawc

Assignees

@electrocucaracha electrocucaracha

@johnbelamaric johnbelamaric

Labels
lgtm needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@debeaueric @johnbelamaric @electrocucaracha