Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rather a comment #4

Closed
wants to merge 18 commits into from
Closed

Rather a comment #4

wants to merge 18 commits into from

Conversation

Olf0
Copy link

@Olf0 Olf0 commented Jan 9, 2023

Rectify comment WRT wording and content

Even though its base (branch obs) is outdated, something similar needs to be implemented to address issue #332, so I commented on the logic and its comment here.

P.S.: Only the last two commits are relevant (the latest one fixes the second last), I have no idea what went wrong, when I checked out the obs branch and committed a single change.

@nephros
Copy link
Owner

nephros commented Jan 9, 2023

Hi.

This 'obs' branch is used by me as an integration branch to merge and test various open branches or PRs from the patchmanager repo proper.

I regularly reset it to master, squash-commit any changes (private or pubic) and push to this branch, to then build on OBS.

Therefore, PRs for this branch are pointless as they will be lost in the next iterations of this integration process. If any changes are required, they need to go to the "source" branch of this process.

In short, please just ignore this branch, its contents are volatile.

I'll look into your two "relevant" commits and see where they should go (it looks like that is one or two branches I have locally).

@nephros nephros closed this Jan 9, 2023
@Olf0
Copy link
Author

Olf0 commented Jan 9, 2023

No, sorry, what a misunderstanding: These two commits shall go nowhere electronically.

It is only about the now even lengthier comment in line 337 meant for you read and intended as a hint (probably something you already considered on your own, meanwhile).

@nephros
Copy link
Owner

nephros commented Jan 9, 2023

Ah heh. What a novel way to send a message!

Someone should build an IM application around git!

Thanks I shall read and ponder!

@nephros
Copy link
Owner

nephros commented Jan 11, 2023

merged into https://github.com/nephros/patchmanager/tree/relax-versioncheck2 for posterity.

@Olf0
Copy link
Author

Olf0 commented Jan 11, 2023

Someone should build an IM application around git!

Good idea for a chat software with logging. Could log either into a public or private repo. 😉
Actually, Delta Chat, an email client disguised as Chat Software is not far from this "concept".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants