-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rather a comment #4
Conversation
… primarily by eliminating the (seemingly) unrelated `# MEDIA_URL SERVER_URL "/" MEDIA_PATH` , see sailfishos-patches#296
Contributes-To: sailfishos-patches#322
Contributes-To: sailfishos-patches#322
Even though this is outdated, something similar needs to be implemented to address [issue \sailfishos-patches#332](sailfishos-patches#322).
Hi. This 'obs' branch is used by me as an integration branch to merge and test various open branches or PRs from the patchmanager repo proper. I regularly reset it to master, squash-commit any changes (private or pubic) and push to this branch, to then build on OBS. Therefore, PRs for this branch are pointless as they will be lost in the next iterations of this integration process. If any changes are required, they need to go to the "source" branch of this process. In short, please just ignore this branch, its contents are volatile. I'll look into your two "relevant" commits and see where they should go (it looks like that is one or two branches I have locally). |
No, sorry, what a misunderstanding: These two commits shall go nowhere electronically. It is only about the now even lengthier comment in line 337 meant for you read and intended as a hint (probably something you already considered on your own, meanwhile). |
Ah heh. What a novel way to send a message! Someone should build an IM application around git! Thanks I shall read and ponder! |
merged into https://github.com/nephros/patchmanager/tree/relax-versioncheck2 for posterity. |
Good idea for a chat software with logging. Could log either into a public or private repo. 😉 |
Rectify comment WRT wording and content
Even though its base (branch
obs
) is outdated, something similar needs to be implemented to address issue #332, so I commented on the logic and its comment here.P.S.: Only the last two commits are relevant (the latest one fixes the second last), I have no idea what went wrong, when I checked out the
obs
branch and committed a single change.