Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added missing factory methods missing in rewrite #176

Merged
merged 1 commit into from Oct 31, 2023
Merged

feat: added missing factory methods missing in rewrite #176

merged 1 commit into from Oct 31, 2023

Conversation

FroostyCodes
Copy link
Contributor

Description

Added the Wanted and Wasted methods missing from the original code

Motivation and Context

These were really good factory methods missing after the rewrite, thus added them back with the support of new template

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

twlite
twlite requested changes Oct 31, 2023
View reviewed changes
Copy link
Member

@twlite twlite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for the PR. Looks like there's a small mistake in your change here, could you fix it?

src/assets/TemplateFactory.ts Outdated Show resolved Hide resolved
@FroostyCodes FroostyCodes force-pushed the feat/add-more-missing-factory-methods branch from 97f389e to a5ba71c Compare October 31, 2023 17:34
@FroostyCodes FroostyCodes reopened this Oct 31, 2023
twlite
twlite approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@twlite twlite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@twlite twlite merged commit 685f340 into neplextech:main Oct 31, 2023
@FroostyCodes FroostyCodes deleted the feat/add-more-missing-factory-methods branch October 31, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twlite twlite twlite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FroostyCodes @twlite