Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NEPTUNE_SYNC_AFTER_STOP_TIMEOUT environment variable #1260

Merged
merged 6 commits into from Mar 15, 2023

Conversation

shnela
Copy link
Contributor

@shnela shnela commented Feb 23, 2023

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you asked the docs owner to review all the updated user-facing interfaces?

@shnela shnela marked this pull request as draft February 23, 2023 10:22
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -71.41 ⚠️

Comparison is base (ee723e2) 71.40% compared to head (ba0946f) 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #1260       +/-   ##
==========================================
- Coverage   71.40%   0.00%   -71.41%     
==========================================
  Files         279     279               
  Lines       13613   13329      -284     
==========================================
- Hits         9721       0     -9721     
- Misses       3892   13329     +9437     
Flag Coverage Δ
e2e ?
unit ?
unit-pull-request 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/neptune/envs.py 0.00% <0.00%> (-100.00%) ⬇️
.../operation_processors/async_operation_processor.py 0.00% <0.00%> (-90.00%) ⬇️

... and 244 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

CHANGELOG.md Outdated Show resolved Hide resolved
src/neptune/common/envs.py Outdated Show resolved Hide resolved
@shnela shnela marked this pull request as ready for review March 1, 2023 14:23
CHANGELOG.md Outdated Show resolved Hide resolved
@Raalsky Raalsky changed the title Add NEPTUNE_SYNC_AFTER_STOP_TIMEOUT parameter Add NEPTUNE_SYNC_AFTER_STOP_TIMEOUT parameter Mar 8, 2023
@Raalsky Raalsky changed the title Add NEPTUNE_SYNC_AFTER_STOP_TIMEOUT parameter Add NEPTUNE_SYNC_AFTER_STOP_TIMEOUT environment variable Mar 8, 2023
PatrykGala
PatrykGala previously approved these changes Mar 15, 2023
@Raalsky Raalsky merged commit 07edd7f into master Mar 15, 2023
@Raalsky Raalsky deleted the jk/sync-after-stop branch March 15, 2023 09:18
@neptune-ai neptune-ai deleted a comment from normandy7 Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants