Use consistent logging #1611
Merged
Use consistent logging #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1611 +/- ##
==========================================
+ Coverage 79.94% 79.97% +0.03%
==========================================
Files 293 293
Lines 14634 14669 +35
==========================================
+ Hits 11699 11732 +33
- Misses 2935 2937 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -184,33 +182,32 @@ def _verify_version(self): | |||
| parsed_version = version.parse(self.client_lib_version) | |||
|
|
|||
| if self._client_config.min_compatible_version and self._client_config.min_compatible_version > parsed_version: | |||
| click.echo( | |||
| styled_msg = click.style( | |||
There was a problem hiding this comment.
Shouldn't we also call logger.error(styled_msg) right after that?
There was a problem hiding this comment.
this change was removed as its part of legacy client
szysad
force-pushed
the
dev/consistent-logging
branch
3 times, most recently
from
89e7484
to
ab28e41
Compare
Raalsky
reviewed
Jan 18, 2024
Raalsky
previously approved these changes
Jan 29, 2024
Raalsky
force-pushed
the
dev/consistent-logging
branch
2 times, most recently
from
7deafa4
to
ab66632
Compare
szysad
force-pushed
the
dev/consistent-logging
branch
from
ab66632
to
72ff56f
Compare
Raalsky
reviewed
Jan 30, 2024
|
Sample output after changes: [neptune] [info ] Neptune initialized. Monitor the logging in the app: https://app.neptune.ai/rafal.neptune/test/e/TES-1274
[neptune] [warning] Info (NVML): NVML Shared Library Not Found. GPU usage metrics may not be reported. For more information, see https://docs.neptune.ai/help/nvml_error/
[neptune] [info ] Shutting down background jobs, please wait a moment...
[neptune] [info ] Done!
[neptune] [info ] Waiting for the remaining 18 operations to synchronize with Neptune. Do not kill this process.
[neptune] [info ] All 18 operations synced, thanks for waiting!
[neptune] [info ] Explore the metadata in the Neptune app: https://app.neptune.ai/rafal.neptune/test/e/TES-1274/metadata
[neptune] [info ] Neptune initialized. Monitor the logging in the app: https://app.neptune.ai/rafal.neptune/test/e/TES-1275
[neptune] [info ] Shutting down background jobs, please wait a moment...
[neptune] [info ] Done!
[neptune] [info ] Waiting for the remaining 18 operations to synchronize with Neptune. Do not kill this process.
[neptune] [info ] All 18 operations synced, thanks for waiting!
[neptune] [info ] Explore the metadata in the Neptune app: https://app.neptune.ai/rafal.neptune/test/e/TES-1275/metadata |
normandy7
reviewed
Jan 30, 2024
Comment on lines
67
to
70
| warning = ( | ||
| "Info (NVML): %s. GPU usage metrics may not be reported. For more information, " | ||
| "see https://docs-legacy.neptune.ai/logging-and-managing-experiment-results" | ||
| "/logging-experiment" | ||
| "-data.html#hardware-consumption " | ||
| ) |
There was a problem hiding this comment.
Under which circumstances does this show? Just wondering whether we should update the ancient docs link.
There was a problem hiding this comment.
This looks to be quite consistent with the circumstances etc. and up-to-date: https://docs.neptune.ai/help/nvml_error/ ?
There was a problem hiding this comment.
Yep! And if the page is not up to snuff, I'll fix it 😉
2 tasks
normandy7
reviewed
Jan 30, 2024
AleksanderWWW
requested changes
Jan 30, 2024
normandy7
previously approved these changes
Jan 30, 2024
- added common logger class - added logging setup and its loading - updated unit tests - TODO: verify, check if no redundant changes are present, add test to check if loggers are logging with common prefix
…nge log format to only desplay log message
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Raalsky
force-pushed
the
dev/consistent-logging
branch
from
12a7570
to
4c70d32
Compare
|
E2E one more time: https://github.com/neptune-ai/neptune-client/actions/runs/7713014109 |
AleksanderWWW
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting checklist
Did you ask the docs owner to review all the user-facing changes?