Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent logging #1611

Merged
merged 20 commits into from
Jan 30, 2024
Merged

Use consistent logging #1611

merged 20 commits into from
Jan 30, 2024

Commits on Jan 30, 2024

  1. replace click echo with neptune.internal.utils.logger

    @Raalsky
    Szymon Sadkowski authored and Raalsky committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    e7b2a59 View commit details
    Browse the repository at this point in the history

  2. update changelog

    @Raalsky
    Szymon Sadkowski authored and Raalsky committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    0d5653e View commit details
    Browse the repository at this point in the history

  3. Introduce global logger class with common stdout handler formatter

    @Raalsky
    Szymon Sadkowski authored and Raalsky committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    9dd49ad View commit details
    Browse the repository at this point in the history

  4. code review bugfix

    @Raalsky
    Szymon Sadkowski authored and Raalsky committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    cb55cb9 View commit details
    Browse the repository at this point in the history

  5. WIP: desc below 

    - added common logger class
- added logging setup and its loading
- updated unit tests
- TODO: verify, check if no redundant changes are present, add test to check if loggers are logging with common prefix
    @Raalsky
    Szymon Sadkowski authored and Raalsky committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    b70abe8 View commit details
    Browse the repository at this point in the history

  6. make root logger CommonPrefixLogger instance, add unit tests for logging

    @Raalsky
    Szymon Sadkowski authored and Raalsky committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    0ad3852 View commit details
    Browse the repository at this point in the history

  7. update const var name

    @Raalsky
    Szymon Sadkowski authored and Raalsky committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    02a39b5 View commit details
    Browse the repository at this point in the history

  8. introduce get_logger function for internal neptune logger getter. Cha… 

    …nge log format to only desplay log message
    @Raalsky
    Szymon Sadkowski authored and Raalsky committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    416dee7 View commit details
    Browse the repository at this point in the history

  9. revert some tests to version without log prefix change

    @Raalsky
    Szymon Sadkowski authored and Raalsky committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    56bb114 View commit details
    Browse the repository at this point in the history

  10. move logging setup order

    @Raalsky
    Szymon Sadkowski authored and Raalsky committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    780e11c View commit details
    Browse the repository at this point in the history

  11. pre-commit format

    @Raalsky
    Szymon Sadkowski authored and Raalsky committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    fce8443 View commit details
    Browse the repository at this point in the history

  12. remove changes applied to legacy client

    @Raalsky
    Szymon Sadkowski authored and Raalsky committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    d45893b View commit details
    Browse the repository at this point in the history

  13. small bugfix

    @Raalsky
    Szymon Sadkowski authored and Raalsky committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    69270fd View commit details
    Browse the repository at this point in the history

  14. init logging in internal.utils.logger and unit test update

    @Raalsky
    Szymon Sadkowski authored and Raalsky committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    7a1a527 View commit details
    Browse the repository at this point in the history

  15. restructure log messages when starting and stoping run

    @Raalsky
    Szymon Sadkowski authored and Raalsky committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    af4c877 View commit details
    Browse the repository at this point in the history

  16. Format adjustments, nvml warning

    @Raalsky
    Raalsky committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    26e3e04 View commit details
    Browse the repository at this point in the history

  17. Fixed NVML

    @Raalsky
    Raalsky committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    188bb6d View commit details
    Browse the repository at this point in the history

  18. Update src/neptune/metadata_containers/metadata_container.py 

    Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
    @Raalsky @normandy7
    Raalsky and normandy7 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    377e19b View commit details
    Browse the repository at this point in the history

  19. Update src/neptune/common/hardware/gpu/gpu_monitor.py 

    Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
    @Raalsky @normandy7
    Raalsky and normandy7 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    81e9708 View commit details
    Browse the repository at this point in the history

  20. No logger for neptune cli

    @Raalsky
    Raalsky committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    4c70d32 View commit details
    Browse the repository at this point in the history