Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename metadata_container to objects #1696

Merged
merged 11 commits into from Mar 14, 2024
Merged

Conversation

AleksanderWWW
Copy link
Contributor

@AleksanderWWW AleksanderWWW commented Mar 14, 2024

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@AleksanderWWW AleksanderWWW changed the base branch from master to dev/2.0 March 14, 2024 15:50
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 74.09%. Comparing base (0fc56bc) to head (440baf9).

Files Patch % Lines
src/neptune/attributes/atoms/string.py 50.00% 1 Missing ⚠️
src/neptune/attributes/attribute.py 50.00% 1 Missing ⚠️
src/neptune/attributes/namespace.py 66.66% 1 Missing ⚠️
src/neptune/attributes/series/string_series.py 50.00% 1 Missing ⚠️
src/neptune/attributes/utils.py 0.00% 1 Missing ⚠️
src/neptune/handler.py 75.00% 1 Missing ⚠️
src/neptune/internal/backgroud_job_list.py 50.00% 1 Missing ⚠️
src/neptune/internal/background_job.py 50.00% 1 Missing ⚠️
...internal/hardware/hardware_metric_reporting_job.py 50.00% 1 Missing ⚠️
...tune/internal/signals_processing/background_job.py 75.00% 1 Missing ⚠️
... and 6 more
Additional details and impacted files
@@             Coverage Diff             @@
##           dev/2.0    #1696      +/-   ##
===========================================
- Coverage    74.12%   74.09%   -0.03%     
===========================================
  Files          338      338              
  Lines        16496    16495       -1     
===========================================
- Hits         12227    12222       -5     
- Misses        4269     4273       +4     
Flag Coverage Δ
macos 76.99% <81.81%> (+<0.01%) ⬆️
py3.7 77.22% <81.81%> (+<0.01%) ⬆️
ubuntu 77.08% <81.81%> (+<0.01%) ⬆️
unit 77.22% <81.81%> (+<0.01%) ⬆️
windows 75.74% <81.81%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AleksanderWWW AleksanderWWW marked this pull request as ready for review March 14, 2024 16:48
@AleksanderWWW AleksanderWWW merged commit 1e9aed6 into dev/2.0 Mar 14, 2024
4 checks passed
@AleksanderWWW AleksanderWWW deleted the aw/neptune-objects branch March 14, 2024 16:59
Raalsky added a commit that referenced this pull request Mar 25, 2024
Co-authored-by: Rafal Jankowski <rafal.jankowski@neptune.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants