Fix failing e2e #31
Merged
Fix failing e2e #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twolodzko
approved these changes
Apr 7, 2023
twolodzko
reviewed
Apr 7, 2023
| @@ -22,8 +22,8 @@ jobs: | |||
| runs-on: ${{ matrix.os }} | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-latest, macos-latest, windows-latest] | |||
There was a problem hiding this comment.
Installation process with python3.10 and windows is a little tricky and in CI causes errors while trying to install matplotlib. Plus we don't use it in our e2e test suite triggered from the client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prophetplotting functionality seems to be incompatible withpandas 2.0.0- calls tomodel.plot(forecast)raiseValueError: Multi-dimensional indexing (e.g. obj[:, None]) is no longer supported. Convert to a numpy array before indexing instead.The tests pass however, with
pandasversions lower than 2.0.0.I tried applying conversion to
numpyon our side, but the right place to do it is in theprophetcode, not ours.If
prophetteam ever update their code, I will remove those version constraints.Also:
introduced running tests with
python 3.10, since the errors this PR aims to resolve originally appeared there.