Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing e2e #31

Merged
merged 4 commits into from Apr 7, 2023
Merged

Fix failing e2e #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fc49bd4
downgrade pandas
AleksanderWWW Apr 7, 2023
8cb286a
check also on 3.10 - errors originally appeared there
AleksanderWWW Apr 7, 2023
44a93eb
versions as strings
AleksanderWWW Apr 7, 2023
3a9c3a2
remove windows due to matplotlib installation errors
AleksanderWWW Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Expand Up @@ -22,8 +22,8 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing Windows?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installation process with python3.10 and windows is a little tricky and in CI causes errors while trying to install matplotlib. Plus we don't use it in our e2e test suite triggered from the client

python-version: [3.9]
os: [ubuntu-latest, macos-latest]
python-version: ["3.9", "3.10"]
steps:
- uses: actions/checkout@v2

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@ importlib-metadata = { version = "*", python = "<3.8" }
# Base requirements
matplotlib = "<=3.4.3"
numpy = "*"
pandas = "*"
pandas = "<2.0.0"
prophet = ">=1.0"
scipy = "*"
statsmodels = ">=0.13.0"
Expand Down